Downgrade RELEASE_ASSERT TO RELEASE_LOG_FAULT for SQLite Class A files
Created attachment 369530 [details]
*** Bug 197789 has been marked as a duplicate of this bug. ***
Probably just makeSafeToUseMemoryMapForPath as we already know the reproducible case?
Created attachment 369577 [details]
There seems to be continuing debate about whether makeSafeToUseMemoryMapForPath in WebKit is a sufficient fix. Let's continue to gather these logs (without crashing) to help inform that discussion.
After discussion with Sihui and Jer, I'm going to land this along with the workaround in bug 197789.
Committed r245197: <https://trac.webkit.org/changeset/245197>
(In reply to Geoffrey Garen from comment #7)
> Committed r245197: <https://trac.webkit.org/changeset/245197>
The patch landed (not the one reviewed) has indentation that does not match the brace structure of the if statement. The call to makeSafeToUseMemoryMapForPath is done unconditionally, not based not the result of isSafeToUseMemoryMapForPath.
Reopening to attach new patch.
Created attachment 369757 [details]
Comment on attachment 369757 [details]
Clearing flags on attachment: 369757
Committed r245253: <https://trac.webkit.org/changeset/245253>
All reviewed patches have been landed. Closing bug.