Bug 197655 - REGRESSION(r244230): Web Automation: use null instead of empty string as success result of scripts when alert is open
Summary: REGRESSION(r244230): Web Automation: use null instead of empty string as succ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, InRadar, Regression
Depends on:
Blocks:
 
Reported: 2019-05-07 03:59 PDT by Carlos Garcia Campos
Modified: 2019-05-07 18:07 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.77 KB, patch)
2019-05-07 04:08 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2019-05-07 03:59:57 PDT
This regressed in r244230, the case of an alert open while running a script is now handled in WebKit side, but an empty string is returned as a result, which is not a valid JSON serialized string. That made all user prompts tests to fail.
Comment 1 Carlos Garcia Campos 2019-05-07 04:08:57 PDT
Created attachment 369274 [details]
Patch
Comment 2 Devin Rousso 2019-05-07 17:39:08 PDT
Comment on attachment 369274 [details]
Patch

rs=me
Comment 3 WebKit Commit Bot 2019-05-07 18:06:18 PDT
Comment on attachment 369274 [details]
Patch

Clearing flags on attachment: 369274

Committed r245046: <https://trac.webkit.org/changeset/245046>
Comment 4 WebKit Commit Bot 2019-05-07 18:06:19 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-05-07 18:07:17 PDT
<rdar://problem/50564291>