Bug 196847 - WebDriver: evaluating javascript shouldn't fail if a dialog is shown
Summary: WebDriver: evaluating javascript shouldn't fail if a dialog is shown
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebDriver (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-04-11 19:48 PDT by Devin Rousso
Modified: 2019-04-12 13:47 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.71 KB, patch)
2019-04-11 19:50 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-04-11 19:48:51 PDT
We currently send an "unexpected alert open error" if a dialog is shown while evaluating javascript, but we really should be silently failing with no data.

<https://github.com/w3c/webdriver/issues/1253>
Comment 1 Devin Rousso 2019-04-11 19:49:01 PDT
<rdar://problem/49609396>
Comment 2 Devin Rousso 2019-04-11 19:50:01 PDT
Created attachment 367279 [details]
Patch
Comment 3 Brian Burg 2019-04-12 13:20:09 PDT
Comment on attachment 367279 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2019-04-12 13:47:01 PDT
Comment on attachment 367279 [details]
Patch

Clearing flags on attachment: 367279

Committed r244230: <https://trac.webkit.org/changeset/244230>
Comment 5 WebKit Commit Bot 2019-04-12 13:47:02 PDT
All reviewed patches have been landed.  Closing bug.