Bug 197220 - Web Inspector: REGRESSION(r238168): Network: preserve log doesn't show main frame main resource changes
Summary: Web Inspector: REGRESSION(r238168): Network: preserve log doesn't show main f...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 191208
Blocks:
  Show dependency tree / graph
 
Reported: 2019-04-23 17:28 PDT by Devin Rousso
Modified: 2019-04-23 18:28 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.83 KB, patch)
2019-04-23 17:31 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (4.16 KB, patch)
2019-04-23 17:41 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (4.43 KB, patch)
2019-04-23 17:44 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-04-23 17:28:01 PDT 
# STEPS TO REPRODUCE:
1. inspect any page
2. clear the network timeline
3. enable "Preserve Log"
4. reload the page
 => main frame main resource missing
Comment 1 Devin Rousso 2019-04-23 17:28:52 PDT 
<rdar://problem/49960464>
Comment 2 Devin Rousso 2019-04-23 17:31:21 PDT 
Created attachment 368090 [details]
Patch
Comment 3 Joseph Pecoraro 2019-04-23 17:34:03 PDT 
Comment on attachment 368090 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368090&action=review

I wonder if we should have some kind of test for this.

> Source/WebInspectorUI/ChangeLog:3
> +        Web Inspector: REGRESSION(r238168): Network: preserve log doesn't show main frame main resource changes

This says main-frame main-resource changes. It also includes sub-frame main-resource changes as well right?
Comment 4 Joseph Pecoraro 2019-04-23 17:34:15 PDT 
Comment on attachment 368090 [details]
Patch

r=me
Comment 5 Devin Rousso 2019-04-23 17:41:48 PDT 
Created attachment 368091 [details]
Patch
Comment 6 Devin Rousso 2019-04-23 17:44:56 PDT 
Created attachment 368092 [details]
Patch
Comment 7 Devin Rousso 2019-04-23 17:46:04 PDT 
Comment on attachment 368090 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=368090&action=review

>> Source/WebInspectorUI/ChangeLog:3
>> +        Web Inspector: REGRESSION(r238168): Network: preserve log doesn't show main frame main resource changes
> 
> This says main-frame main-resource changes. It also includes sub-frame main-resource changes as well right?

Good point.  It should also benefit that as well.
Comment 8 WebKit Commit Bot 2019-04-23 18:28:54 PDT 
Comment on attachment 368092 [details]
Patch

Clearing flags on attachment: 368092

Committed r244577: <https://trac.webkit.org/changeset/244577>
Comment 9 WebKit Commit Bot 2019-04-23 18:28:55 PDT 
All reviewed patches have been landed.  Closing bug.