Bug 191208 – Web Inspector: Network Graphs are missing minimum sizes, might have no graph at all

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Created attachment 353727 [details]
[IMAGE] Issue

Network Graphs are missing minimum sizes, might have no graph at all

Steps to Reproduce:
1. Inspect webkit.org
2. Ensure you're using the network cache
3. Reload the page
  => Some rows are blank, unclear where to click to get resource load timings / details

[Joseph Pecoraro]

Created attachment 353728 [details]
[IMAGE] Original Network Tab

[Joseph Pecoraro]

Created attachment 353729 [details]
[IMAGE] Current Network Tab

[Joseph Pecoraro]

Notice how before, even if the load was 0ms there was still a minimum appearance. That has gone away. I feel this is a regression in the user experience, as you still want to see _when_ the load happened, even if it took effectively no time.

[Devin Rousso]

Created attachment 354581 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 354581 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=354581&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:793
> +            if (endTimestamp - startTimestamp < 0)
> +                return null;

When can this happen?

[Devin Rousso]

Created attachment 354780 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 354780 [details]
Patch

Clearing flags on attachment: 354780

Committed r238168: <https://trac.webkit.org/changeset/238168>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46056899>