Bug 196920 - Web Inspector: REGRESSION(r244268): Canvas: navigation sidebar no longer appears
Summary: Web Inspector: REGRESSION(r244268): Canvas: navigation sidebar no longer appears
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on: 196888
Blocks:
  Show dependency tree / graph
 
Reported: 2019-04-15 11:31 PDT by Devin Rousso
Modified: 2019-04-15 12:57 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.36 KB, patch)
2019-04-15 11:37 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (2.38 KB, patch)
2019-04-15 11:39 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-04-15 11:31:44 PDT 
# STEPS TO REPRODUCE:
1. inspect any page with a <canvas>
2. go to the Canvas tab
3. click on one of the <canvas> cards
 => navigation sidebar does not show (and the button to toggle it is disabled)
Comment 1 Radar WebKit Bug Importer 2019-04-15 11:31:57 PDT 
<rdar://problem/49910618>
Comment 2 Devin Rousso 2019-04-15 11:37:01 PDT 
Created attachment 367432 [details]
Patch
Comment 3 Devin Rousso 2019-04-15 11:39:53 PDT 
Created attachment 367433 [details]
Patch
Comment 4 Timothy Hatcher 2019-04-15 12:30:53 PDT 
Comment on attachment 367433 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367433&action=review

> Source/WebInspectorUI/ChangeLog:12
> +        Now that we no longer call `addSubview` when adding a sidebar panel, we can't check to see
> +        if `parentSidebar` has been set, as that is just an alias for `parentView`.

Told you it would cause regressions. :) Maybe parentSidebar should change, since the Sidebar still holds it and shows it in the navigation bar.
Comment 5 WebKit Commit Bot 2019-04-15 12:57:04 PDT 
Comment on attachment 367433 [details]
Patch

Clearing flags on attachment: 367433

Committed r244282: <https://trac.webkit.org/changeset/244282>
Comment 6 WebKit Commit Bot 2019-04-15 12:57:06 PDT 
All reviewed patches have been landed.  Closing bug.