Bug 196888 - Web Inspector: sidebar panels shouldn't be added as subviews unless visible
Summary: Web Inspector: sidebar panels shouldn't be added as subviews unless visible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks: 196920
  Show dependency treegraph
 
Reported: 2019-04-12 18:22 PDT by Devin Rousso
Modified: 2019-04-15 12:12 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.16 KB, patch)
2019-04-12 18:31 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-04-12 18:22:08 PDT
Although most of the top-level sidebar panel subclasses will bail if they're not visible, subviews don't have knowledge of that state and may still layout even when the parent panel is hidden.  The only subview of a sidebar should the currently visible panel.
Comment 1 Radar WebKit Bug Importer 2019-04-12 18:22:28 PDT
<rdar://problem/49870659>
Comment 2 Devin Rousso 2019-04-12 18:31:46 PDT
Created attachment 367367 [details]
Patch
Comment 3 Timothy Hatcher 2019-04-15 10:05:25 PDT
Comment on attachment 367367 [details]
Patch

We should keep an eye on this change, it could introduce regressions.
Comment 4 WebKit Commit Bot 2019-04-15 10:27:33 PDT
Comment on attachment 367367 [details]
Patch

Clearing flags on attachment: 367367

Committed r244268: <https://trac.webkit.org/changeset/244268>
Comment 5 WebKit Commit Bot 2019-04-15 10:27:35 PDT
All reviewed patches have been landed.  Closing bug.