RESOLVED FIXED 196888
Web Inspector: sidebar panels shouldn't be added as subviews unless visible 
https://bugs.webkit.org/show_bug.cgi?id=196888
Summary Web Inspector: sidebar panels shouldn't be added as subviews unless visible
Devin Rousso
Reported 2019-04-12 18:22:08 PDT
Although most of the top-level sidebar panel subclasses will bail if they're not visible, subviews don't have knowledge of that state and may still layout even when the parent panel is hidden. The only subview of a sidebar should the currently visible panel.
Attachments
Patch (3.16 KB, patch)
2019-04-12 18:31 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2019-04-12 18:22:28 PDT
<rdar://problem/49870659>
Devin Rousso
Comment 2 2019-04-12 18:31:46 PDT
Created attachment 367367 [details] Patch
Timothy Hatcher
Comment 3 2019-04-15 10:05:25 PDT
Comment on attachment 367367 [details] Patch We should keep an eye on this change, it could introduce regressions.
WebKit Commit Bot
Comment 4 2019-04-15 10:27:33 PDT
Comment on attachment 367367 [details] Patch Clearing flags on attachment: 367367 Committed r244268: <https://trac.webkit.org/changeset/244268>
WebKit Commit Bot
Comment 5 2019-04-15 10:27:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.