RESOLVED FIXED 196897
[ews-build] Do not run clean build by default on EWS builders
https://bugs.webkit.org/show_bug.cgi?id=196897
Summary [ews-build] Do not run clean build by default on EWS builders
Aakash Jain
Reported 2019-04-13 06:23:00 PDT
Builders on ews-build don't need to run clean builds. Incremental builds are fine for EWS. clean builds take a lot longer without much value addition for EWS. Old EWS also doesn't run clean builds, ews-build should do the same. ews-build is currently running clean builds (even though we have not explicitly specified clean build in our configuration).
Attachments
Patch (2.10 KB, patch)
2019-04-13 08:06 PDT, Aakash Jain
lforschler: review+
Alexey Proskuryakov
Comment 1 2019-04-13 07:27:52 PDT
To elaborate on old EWS behavior, it dies build clean when retrying. Otherwise, changes that require clean rebuild would be breaking EWS permanently, until manual intervention.
Aakash Jain
Comment 2 2019-04-13 08:06:12 PDT
(In reply to Alexey Proskuryakov from comment #1) > To elaborate on old EWS behavior, it does build clean when retrying. > Otherwise, changes that require clean rebuild would be breaking EWS permanently, until manual intervention. Yes, we will continue to do clean build on retry (unapply-patch step removes untracked files including WebKitBuild directory).
Aakash Jain
Comment 3 2019-04-13 08:06:44 PDT
Lucas Forschler
Comment 4 2019-04-15 13:02:46 PDT
Comment on attachment 367387 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367387&action=review > Tools/ChangeLog:10 > + file is present, during the Source checkout, Buildbot clean the working directory completely (including removing nit: buildbot cleans
Aakash Jain
Comment 5 2019-04-15 13:12:42 PDT
Radar WebKit Bug Importer
Comment 6 2019-04-15 13:13:22 PDT
Note You need to log in before you can comment on or make changes to this bug.