Bug 196897 – [ews-build] Do not run clean build by default on EWS builders

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

Builders on ews-build don't need to run clean builds. Incremental builds are fine for EWS. clean builds take a lot longer without much value addition for EWS. Old EWS also doesn't run clean builds, ews-build should do the same.

ews-build is currently running clean builds (even though we have not explicitly specified clean build in our configuration).

[Alexey Proskuryakov]

To elaborate on old EWS behavior, it dies build clean when retrying. Otherwise, changes that require clean rebuild would be breaking EWS permanently, until manual intervention.

[Aakash Jain]

(In reply to Alexey Proskuryakov from comment #1)
> To elaborate on old EWS behavior, it does build clean when retrying.
> Otherwise, changes that require clean rebuild would be breaking EWS permanently, until manual intervention.
Yes, we will continue to do clean build on retry (unapply-patch step removes untracked files including WebKitBuild directory).

[Aakash Jain]

Created attachment 367387 [details]
Patch

[Lucas Forschler]

Comment on attachment 367387 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=367387&action=review

> Tools/ChangeLog:10
> +        file is present, during the Source checkout, Buildbot clean the working directory completely (including removing 

nit: buildbot cleans

[Aakash Jain]

Committed r244283: <https://trac.webkit.org/changeset/244283>

[Radar WebKit Bug Importer]

<rdar://problem/49914488>