Bug 195851 - [ews-build] Don't run clean builds on EWS builders
Summary: [ews-build] Don't run clean builds on EWS builders
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-16 08:48 PDT by Aakash Jain
Modified: 2019-04-13 06:40 PDT (History)
9 users (show)

See Also:

Attachments
Patch (1.24 KB, patch)
2019-03-16 08:49 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-03-16 08:48:25 PDT 
Builders on ews-build don't need to run clean builds. Incremental builds are fine for EWS. clean builds take a lot longer without much value addition for EWS. The current EWS also doesn't run clean builds, ews-build should do the same.
Comment 1 Aakash Jain 2019-03-16 08:49:16 PDT 
Created attachment 364932 [details]
Patch
Comment 2 Geoffrey Garen 2019-03-16 13:48:41 PDT 
Comment on attachment 364932 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2019-03-16 20:50:52 PDT 
Comment on attachment 364932 [details]
Patch

Clearing flags on attachment: 364932

Committed r243050: <https://trac.webkit.org/changeset/243050>
Comment 4 WebKit Commit Bot 2019-03-16 20:50:53 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-03-16 20:51:16 PDT 
<rdar://problem/48958641>
Comment 6 Jonathan Bedard 2019-03-18 09:01:50 PDT 
Question about this change: What happens if we need a clean build for some reason? Is there a mechanism to, for example, force a clean build if the build fails?
Comment 7 Jonathan Bedard 2019-03-18 11:08:24 PDT 
(In reply to Jonathan Bedard from comment #6)
> Question about this change: What happens if we need a clean build for some
> reason? Is there a mechanism to, for example, force a clean build if the
> build fails?

Discussed this on IRC with Aakash. Turns out, the code which cleans up after a patch fails to build removes the build directory. So we shouldn't need to do anything special to handle this case.