Bug 196665 - Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
Summary: Clicking "Go Back" from a safe browsing warning from an iframe should navigat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on: 196688
Blocks:
  Show dependency tree / graph
 
Reported: 2019-04-05 16:44 PDT by Alex Christensen
Modified: 2019-04-09 12:08 PDT (History)
8 users (show)

See Also:

Attachments
Patch (8.29 KB, patch)
2019-04-05 16:46 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (8.25 KB, patch)
2019-04-05 17:07 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (8.31 KB, patch)
2019-04-08 15:48 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-04-05 16:44:23 PDT 
Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
Comment 1 Alex Christensen 2019-04-05 16:46:58 PDT 
Created attachment 366858 [details]
Patch
Comment 2 Geoffrey Garen 2019-04-05 16:58:06 PDT 
Comment on attachment 366858 [details]
Patch

r=me
Comment 3 Alex Christensen 2019-04-05 17:07:50 PDT 
Created attachment 366860 [details]
Patch
Comment 4 Alex Christensen 2019-04-05 17:10:40 PDT 
https://trac.webkit.org/changeset/243956/webkit
Comment 5 Radar WebKit Bug Importer 2019-04-05 17:11:15 PDT 
<rdar://problem/49662311>
Comment 6 Aakash Jain 2019-04-05 19:12:52 PDT 
This patch seems to have introduced an API test failure TestWebKitAPI.SafeBrowsing.WKWebViewGoBackIFrame

e.g.: See API test failure in https://ews-build.webkit.org/#/builders/9/builds/197 and https://ews-build.webkit.org/#/builders/9/builds/198

Note that we do have EWS for API test now, but EWS didn't get a chance to run API tests on this patch before this patch was landed.
Comment 7 Aakash Jain 2019-04-05 20:20:38 PDT 
Note that the test is "Timing Out" (not failing).

Similarly occurrence on build.webkit.org:
https://build.webkit.org/builders/Apple%20iOS%2012%20Simulator%20Release%20WK2%20%28Tests%29/builds/3494/steps/run-api-tests/logs/stdio
Comment 8 Alexey Proskuryakov 2019-04-07 16:54:47 PDT 
Please wait for EWS before landing patches.
Comment 9 WebKit Commit Bot 2019-04-07 19:55:21 PDT 
Re-opened since this is blocked by bug 196688
Comment 10 Alex Christensen 2019-04-08 15:48:20 PDT 
Created attachment 366991 [details]
Patch
Comment 11 Alex Christensen 2019-04-08 15:49:57 PDT 
(In reply to Alexey Proskuryakov from comment #8)
> Please wait for EWS before landing patches.
As one of the bigger supporters of API tests on EWS, I sincerely apologize and promise to do better in the future.  I am, contrary to what my behavior last week would indicate, quite glad that we have this new tool.  Thanks for getting it working!
Comment 12 WebKit Commit Bot 2019-04-09 12:08:00 PDT 
Comment on attachment 366991 [details]
Patch

Clearing flags on attachment: 366991

Committed r244089: <https://trac.webkit.org/changeset/244089>
Comment 13 WebKit Commit Bot 2019-04-09 12:08:02 PDT 
All reviewed patches have been landed.  Closing bug.