Bug 196608 – Update touch-action region on property changes

• Status: RESOLVED
• Resolution: FIXED
• Component: Scrolling

[Antti Koivisto]

Verify that we react do changes to touch-action correctly.

[Antti Koivisto]

Created attachment 366928 [details]
patch

[Antti Koivisto]

Created attachment 366934 [details]
patch

[Radar WebKit Bug Importer]

<rdar://problem/49706912>

[Simon Fraser (smfr)]

Comment on attachment 366934 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366934&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:2489
> +    m_owningLayer.invalidateEventRegion();

It's a shame to trigger expensive event region building for non-layout changes like color changes. Can we use a StyleDiff somewhere instead? Imagine an animation of background-color triggering region rebuilds every frame :(

[Antti Koivisto]

> It's a shame to trigger expensive event region building for non-layout
> changes like color changes. Can we use a StyleDiff somewhere instead?
> Imagine an animation of background-color triggering region rebuilds every
> frame :(

We could certainly implement finer grained invalidation. Not sure yet if it is worth additional complexity, in most cases (at least when touch-action is not involved) region building should be very cheap due to ability to bail out early in the common case. We'll see if it actually shows up in profiles.

[WebKit Commit Bot]

Comment on attachment 366934 [details]
patch

Clearing flags on attachment: 366934

Committed r244037: <https://trac.webkit.org/changeset/244037>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.