Bug 196608 - Update touch-action region on property changes
Summary: Update touch-action region on property changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 194813
  Show dependency treegraph
 
Reported: 2019-04-04 09:01 PDT by Antti Koivisto
Modified: 2019-04-08 13:33 PDT (History)
4 users (show)

See Also:


Attachments
patch (9.36 KB, patch)
2019-04-08 05:53 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff
patch (9.61 KB, patch)
2019-04-08 07:23 PDT, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2019-04-04 09:01:19 PDT
Verify that we react do changes to touch-action correctly.
Comment 1 Antti Koivisto 2019-04-08 05:53:34 PDT
Created attachment 366928 [details]
patch
Comment 2 Antti Koivisto 2019-04-08 07:23:38 PDT
Created attachment 366934 [details]
patch
Comment 3 Radar WebKit Bug Importer 2019-04-08 12:45:15 PDT
<rdar://problem/49706912>
Comment 4 Simon Fraser (smfr) 2019-04-08 13:01:50 PDT
Comment on attachment 366934 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366934&action=review

> Source/WebCore/rendering/RenderLayerBacking.cpp:2489
> +    m_owningLayer.invalidateEventRegion();

It's a shame to trigger expensive event region building for non-layout changes like color changes. Can we use a StyleDiff somewhere instead? Imagine an animation of background-color triggering region rebuilds every frame :(
Comment 5 Antti Koivisto 2019-04-08 13:07:50 PDT
> It's a shame to trigger expensive event region building for non-layout
> changes like color changes. Can we use a StyleDiff somewhere instead?
> Imagine an animation of background-color triggering region rebuilds every
> frame :(

We could certainly implement finer grained invalidation. Not sure yet if it is worth additional complexity, in most cases (at least when touch-action is not involved) region building should be very cheap due to ability to bail out early in the common case. We'll see if it actually shows up in profiles.
Comment 6 WebKit Commit Bot 2019-04-08 13:33:00 PDT
Comment on attachment 366934 [details]
patch

Clearing flags on attachment: 366934

Committed r244037: <https://trac.webkit.org/changeset/244037>
Comment 7 WebKit Commit Bot 2019-04-08 13:33:03 PDT
All reviewed patches have been landed.  Closing bug.