Bug 194813 – [iOS] Correctly handle overlapping regions for elements with a touch-action property

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Antoine Quint]

The code we currently use to gather regions for elements with touch-action set on them is very basic and does not account for any element that might overlap it. For instance, having "touch-action: none" on an element and having another element overlap in a different hierarchy means the other element is also treated to have "touch-action: none".

[Radar WebKit Bug Importer]

<rdar://problem/48194708>

[Antti Koivisto]

Created attachment 366929 [details]
wip

[Antti Koivisto]

Created attachment 366932 [details]
wip

[Antti Koivisto]

Moved the part that computes the touch actions from remote layer tree to bug 196701 for review.

[Antoine Quint]

Found an issue where elements with "display: inline-block" don't have a touch-action region, see https://bugs.webkit.org/show_bug.cgi?id=197281.

[Antoine Quint]

Created attachment 369410 [details]
Patch

[EWS Watchlist]

Comment on attachment 369410 [details]
Patch

Attachment 369410 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/12136954

New failing tests:
security/contentSecurityPolicy/video-with-file-url-allowed-by-media-src-star.html
legacy-animation-engine/compositing/reflections/load-video-in-reflection.html

[EWS Watchlist]

Created attachment 369438 [details]
Archive of layout-test-results from ews213 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews213  Port: win-future  Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

[Antti Koivisto]

Comment on attachment 369410 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=369410&action=review

r=me

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1342
> +            if (!touchActions.contains(WebCore::TouchAction::PinchZoom))
> +                _webView.scrollView.pinchGestureRecognizer.enabled = NO;

Where does this thing get reset?

[Antoine Quint]

(In reply to Antti Koivisto from comment #9)
> Comment on attachment 369410 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=369410&action=review
> 
> r=me
> 
> > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1342
> > +            if (!touchActions.contains(WebCore::TouchAction::PinchZoom))
> > +                _webView.scrollView.pinchGestureRecognizer.enabled = NO;
> 
> Where does this thing get reset?

I'm not actually sure, but testing indicates that the value is reset as expected. Maybe UIKit performs that reset internally, I couldn't find any code in WebKit that would do this.

[Antoine Quint]

Committed r245112: <https://trac.webkit.org/changeset/245112>