Bug 196593 – [ATK] Use a smart pointer for AccessibilityObject wrapper and remove GTK specific code

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Carlos Garcia Campos]

We have specific code for GTK to get/set the wrapper only because we don't use smart pointers.

[Radar WebKit Bug Importer]

<rdar://problem/49599153>

[Carlos Garcia Campos]

Created attachment 366703 [details]
Patch

[Michael Catanzaro]

Comment on attachment 366703 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366703&action=review

> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:324
>              return 0;

return nullptr;

> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:350
> +    return coreParent ? ATK_OBJECT(coreParent->wrapper()) : nullptr;

Two more opportunities to return nullptr up above, as well.

[Carlos Garcia Campos]

(In reply to Michael Catanzaro from comment #3)
> Comment on attachment 366703 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=366703&action=review
> 
> > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:324
> >              return 0;
> 
> return nullptr;
> 
> > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:350
> > +    return coreParent ? ATK_OBJECT(coreParent->wrapper()) : nullptr;
> 
> Two more opportunities to return nullptr up above, as well.

WebKitAccessibleWrapperAtk is cleaned up in bug #196601

[Carlos Garcia Campos]

Committed r243928: <https://trac.webkit.org/changeset/243928>