Bug 196593 - [ATK] Use a smart pointer for AccessibilityObject wrapper and remove GTK specific code
Summary: [ATK] Use a smart pointer for AccessibilityObject wrapper and remove GTK spec...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, InRadar
Depends on:
Blocks:
 
Reported: 2019-04-04 01:20 PDT by Carlos Garcia Campos
Modified: 2019-04-05 00:35 PDT (History)
4 users (show)

See Also:


Attachments
Patch (33.64 KB, patch)
2019-04-04 01:24 PDT, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2019-04-04 01:20:31 PDT
We have specific code for GTK to get/set the wrapper only because we don't use smart pointers.
Comment 1 Radar WebKit Bug Importer 2019-04-04 01:20:42 PDT
<rdar://problem/49599153>
Comment 2 Carlos Garcia Campos 2019-04-04 01:24:33 PDT
Created attachment 366703 [details]
Patch
Comment 3 Michael Catanzaro 2019-04-04 08:41:42 PDT
Comment on attachment 366703 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366703&action=review

> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:324
>              return 0;

return nullptr;

> Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:350
> +    return coreParent ? ATK_OBJECT(coreParent->wrapper()) : nullptr;

Two more opportunities to return nullptr up above, as well.
Comment 4 Carlos Garcia Campos 2019-04-05 00:34:56 PDT
(In reply to Michael Catanzaro from comment #3)
> Comment on attachment 366703 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=366703&action=review
> 
> > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:324
> >              return 0;
> 
> return nullptr;
> 
> > Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:350
> > +    return coreParent ? ATK_OBJECT(coreParent->wrapper()) : nullptr;
> 
> Two more opportunities to return nullptr up above, as well.

WebKitAccessibleWrapperAtk is cleaned up in bug #196601
Comment 5 Carlos Garcia Campos 2019-04-05 00:35:30 PDT
Committed r243928: <https://trac.webkit.org/changeset/243928>