Bug 196601 – [ATK] Cleanup accessible wrapper base class

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Carlos Garcia Campos]

.

[Radar WebKit Bug Importer]

<rdar://problem/49606912>

[Carlos Garcia Campos]

Created attachment 366713 [details]
Patch

[Carlos Garcia Campos]

Created attachment 366803 [details]
Rebased patch

[Mario Sanchez Prada]

Comment on attachment 366803 [details]
Rebased patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366803&action=review

It looks good to me, only one comment on that there's a part of the code that looks like could be removed altogether (either now or in a follow-up patch)

> Source/WebCore/accessibility/atk/WebKitAccessible.cppSource/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp:369
> +        auto* atkParent = parent ? ATK_OBJECT(parent->wrapper()) : nullptr;

It seems like this will always yield nullptr to atkParent, since `parent == nullptr` already if you made it here... meaning that the for loop below won't ever be executed.

Actually, it seems that the whole `(!parent && isRootObject(coreObject)) { ... }` block can be removed, as all we can do if `parent == nullptr` at this point is to return -1, which is what the if block right after this one does.

However, I think it's better to keep this for now as this patch is just about cleaning things up and translating, so feel free to address that in a follow-up patch.

[Carlos Garcia Campos]

Committed r243970: <https://trac.webkit.org/changeset/243970>