Bug 196535 - [ATK] Set ATK_STATE_TRANSIENT on the atk socket until it's embedded
Summary: [ATK] Set ATK_STATE_TRANSIENT on the atk socket until it's embedded
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on: 196534
  Show dependency treegraph
Reported: 2019-04-03 05:54 PDT by Carlos Garcia Campos
Modified: 2019-04-05 01:39 PDT (History)
4 users (show)

See Also:

Patch (2.60 KB, patch)
2019-04-03 05:56 PDT, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2019-04-03 05:54:25 PDT
This way the properties are not cached. Right now, if number of children is queried before the socket is embedded, 0 is returned and cached, so ATs don't see the child even after the socket has been embedded.
Comment 1 Carlos Garcia Campos 2019-04-03 05:56:50 PDT
Created attachment 366593 [details]
Comment 2 Carlos Garcia Campos 2019-04-03 22:51:44 PDT
Committed r243862: <https://trac.webkit.org/changeset/243862>
Comment 3 Mario Sanchez Prada 2019-04-05 01:39:11 PDT
Another late drive-by review: lgtm