Bug 196534 - [ATK] Embed the AtkSocket as soon as we receive the plug ID
Summary: [ATK] Embed the AtkSocket as soon as we receive the plug ID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Blocks: 196535
  Show dependency treegraph
Reported: 2019-04-03 05:43 PDT by Carlos Garcia Campos
Modified: 2019-04-05 01:38 PDT (History)
7 users (show)

See Also:

Patch (4.25 KB, patch)
2019-04-03 05:45 PDT, Carlos Garcia Campos
mcatanzaro: review+
Details | Formatted Diff | Diff
Archive of layout-test-results from ews549 for win-future (5.64 MB, application/zip)
2019-04-03 06:46 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2019-04-03 05:43:59 PDT
We are currently storing the ID and waiting for the next time get_accessible is called to embed the socket. We can simply embed the socket when the plug ID is received.
Comment 1 Carlos Garcia Campos 2019-04-03 05:45:56 PDT
Created attachment 366592 [details]
Comment 2 EWS Watchlist 2019-04-03 05:49:15 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 EWS Watchlist 2019-04-03 06:46:37 PDT
Comment on attachment 366592 [details]

Attachment 366592 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/11750608

Number of test failures exceeded the failure limit.
Comment 4 EWS Watchlist 2019-04-03 06:46:39 PDT
Created attachment 366597 [details]
Archive of layout-test-results from ews549 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews549  Port: win-future  Platform: CYGWIN_NT-10.0-2.11.1-0.329-5-3-x86_64-64bit
Comment 5 Michael Catanzaro 2019-04-03 08:07:13 PDT
Comment on attachment 366592 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=366592&action=review

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1236
>          // Set the parent not to break bottom-up navigation.

Might as well fix this while you're at it: "to not break"
Comment 6 Carlos Garcia Campos 2019-04-03 22:50:29 PDT
Committed r243861: <https://trac.webkit.org/changeset/243861>
Comment 7 Mario Sanchez Prada 2019-04-05 01:38:06 PDT
Late-to-the-party drive-by review, just to confirm I checked this: lgtm