Bug 196534 – [ATK] Embed the AtkSocket as soon as we receive the plug ID

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

We are currently storing the ID and waiting for the next time get_accessible is called to embed the socket. We can simply embed the socket when the plug ID is received.

[Carlos Garcia Campos]

Created attachment 366592 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[EWS Watchlist]

Comment on attachment 366592 [details]
Patch

Attachment 366592 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/11750608

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 366597 [details]
Archive of layout-test-results from ews549 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews549  Port: win-future  Platform: CYGWIN_NT-10.0-2.11.1-0.329-5-3-x86_64-64bit

[Michael Catanzaro]

Comment on attachment 366592 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=366592&action=review

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1236
>          // Set the parent not to break bottom-up navigation.

Might as well fix this while you're at it: "to not break"

[Carlos Garcia Campos]

Committed r243861: <https://trac.webkit.org/changeset/243861>

[Mario Sanchez Prada]

Late-to-the-party drive-by review, just to confirm I checked this: lgtm