Add basic layout test coverage for File Picker on iOS.
Created attachment 365984 [details] Patch
Created attachment 365989 [details] Patch
Comment on attachment 365989 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365989&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7018 > + auto* result = @{ userInterfaceItem: [_fileUploadPanel currentAvailableActionTitles] }; Nit - would be cleaner just to return @{ ~ } > Tools/WebKitTestRunner/ios/TestControllerIOS.mm:53 > +static void overridePresentViewController() Nit - maybe overridePresentViewControllerOrPopover, since it's used for both purposes? > LayoutTests/fast/forms/ios/file-upload-panel.html:62 > + UIHelper.activateElement(testInput).then(() => { > + getFileUploadPickerMenuItems().then((_items) => { > + items = _items; > + shouldBeTrue("areArraysEqual(items, " + expectedMenuItems + ")"); > + debug(""); > + dismissFilePicker().then(() => { resolve(); }); > + }); > + }); Nit - IMO this function could be made cleaner using async - await, but either way it's fine.
Created attachment 365999 [details] Patch
Comment on attachment 365999 [details] Patch Clearing flags on attachment: 365999 Committed r243523: <https://trac.webkit.org/changeset/243523>
All reviewed patches have been landed. Closing bug.
<rdar://problem/49299305>