Bug 196205 – Regression(r242369) Trying to change profile picture on linked in shows file picker, not the image picker

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Trying to change profile picture on linked in shows file picker, not the image picker since r242369.

[Chris Dumez]

<rdar://problem/49083324>

[Chris Dumez]

Created attachment 365867 [details]
Patch

[Chris Dumez]

Created attachment 365872 [details]
Patch

[Geoffrey Garen]

Comment on attachment 365872 [details]
Patch

r=me

Can we regression test this? If opening the panel is an issue, maybe use a low-level API test?

[Chris Dumez]

(In reply to Geoffrey Garen from comment #4)
> Comment on attachment 365872 [details]
> Patch
> 
> r=me
> 
> Can we regression test this? If opening the panel is an issue, maybe use a
> low-level API test?

I discussed it with Wenson and it does not seem that proper automated testing would be practical at the moment. However, we can probably write a low-level API test.

[Chris Dumez]

Looks like I can write a layout test for this, almost there...

[Chris Dumez]

Comment on attachment 365872 [details]
Patch

Will follow up for the test, it is taking longer than I hoped.

[WebKit Commit Bot]

Comment on attachment 365872 [details]
Patch

Rejecting attachment 365872 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 365872, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=365872&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=196205&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 365872 from bug 196205.
Fetching: https://bugs.webkit.org/attachment.cgi?id=365872
Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebKit/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date
W: 444c0eb48870e7ca29baa97530aecb1ec213e12f and refs/remotes/origin/master differ, using rebase:
:040000 040000 506332e0ce534159bb852cdf943d208e004c5868 951cfcaa2cada3ce5d92e403825aefbe1dcfae66 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	Source/WebKit/ChangeLog

ERROR from SVN:
Item is out of date: File '/trunk/Source/WebKit/ChangeLog' is out of date
W: 444c0eb48870e7ca29baa97530aecb1ec213e12f and refs/remotes/origin/master differ, using rebase:
:040000 040000 506332e0ce534159bb852cdf943d208e004c5868 951cfcaa2cada3ce5d92e403825aefbe1dcfae66 M	Source
Current branch master is up to date.
ERROR: Not all changes have been committed into SVN, however the committed
ones (if any) seem to be successfully integrated into the working tree.
Please see the above messages for details.


Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: https://webkit-queues.webkit.org/results/11668782

[WebKit Commit Bot]

Comment on attachment 365872 [details]
Patch

Clearing flags on attachment: 365872

Committed r243485: <https://trac.webkit.org/changeset/243485>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.