Bug 196152 - Placate exception check validation in constructJSWebAssemblyLinkError().
Summary: Placate exception check validation in constructJSWebAssemblyLinkError().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-22 10:08 PDT by Mark Lam
Modified: 2019-03-24 08:41 PDT (History)
7 users (show)

See Also:

Attachments
proposed patch. (2.87 KB, patch)
2019-03-22 10:13 PDT, Mark Lam 		msaboff: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2019-03-22 10:08:40 PDT 
<rdar://problem/49145257>
Comment 1 Radar WebKit Bug Importer 2019-03-22 10:10:43 PDT 
<rdar://problem/49157806>
Comment 2 Mark Lam 2019-03-22 10:12:00 PDT 
<rdar://problem/49145257>
Comment 3 Mark Lam 2019-03-22 10:13:54 PDT 
Created attachment 365739 [details]
proposed patch.
Comment 4 Michael Saboff 2019-03-22 10:17:13 PDT 
Comment on attachment 365739 [details]
proposed patch.

r=me
Comment 5 Mark Lam 2019-03-22 10:22:19 PDT 
Thanks for the review.  Landed in r243386: <http://trac.webkit.org/r243386>.
Comment 6 Dominik Inführ 2019-03-24 08:41:00 PDT 
web-assembly-link-error-exception-check.js is failing on 32-bit systems because of missing WASM support. I've uploaded a patch that moves this test into JSTests/wasm/stress: https://bugs.webkit.org/show_bug.cgi?id=196187