Bug 196187 - [JSC] Move test into directory for WASM tests
Summary: [JSC] Move test into directory for WASM tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-24 08:37 PDT by Dominik Inführ
Modified: 2019-03-25 10:01 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.58 KB, patch)
2019-03-24 08:38 PDT, Dominik Inführ
no flags Details | Formatted Diff | Diff
Patch (1.57 KB, patch)
2019-03-24 09:35 PDT, Dominik Inführ
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews202 for win-future (12.92 MB, application/zip)
2019-03-24 15:04 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dominik Inführ 2019-03-24 08:37:00 PDT
[JSC] Move test into directory for WASM tests
Comment 1 Dominik Inführ 2019-03-24 08:38:28 PDT
Created attachment 365827 [details]
Patch
Comment 2 Mark Lam 2019-03-24 09:15:41 PDT
Comment on attachment 365827 [details]
Patch

r=me but please move to JSTests/was/regress instead.  Thanks.
Comment 3 Mark Lam 2019-03-24 09:15:58 PDT
(In reply to Mark Lam from comment #2)
> Comment on attachment 365827 [details]
> Patch
> 
> r=me but please move to JSTests/was/regress instead.  Thanks.

I meant JSTests/wasm/regress.
Comment 4 Dominik Inführ 2019-03-24 09:35:34 PDT
Created attachment 365832 [details]
Patch
Comment 5 EWS Watchlist 2019-03-24 15:04:25 PDT
Comment on attachment 365832 [details]
Patch

Attachment 365832 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/11648844

New failing tests:
animations/resume-after-page-cache.html
js/dom/custom-constructors.html
Comment 6 EWS Watchlist 2019-03-24 15:04:37 PDT
Created attachment 365839 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Comment 7 WebKit Commit Bot 2019-03-24 17:41:31 PDT
Comment on attachment 365832 [details]
Patch

Clearing flags on attachment: 365832

Committed r243428: <https://trac.webkit.org/changeset/243428>
Comment 8 WebKit Commit Bot 2019-03-24 17:41:32 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-03-24 17:45:16 PDT
<rdar://problem/49201878>
Comment 10 Dominik Inführ 2019-03-25 10:01:29 PDT
Unfortunately this wasn't enough, runDefault causes the test to run immediately. https://bugs.webkit.org/show_bug.cgi?id=196206 makes runDefault conditional.