Bug 196105 - Make a SelectValue subclass of B3::Value
Summary: Make a SelectValue subclass of B3::Value
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robin Morisset
URL:
Keywords:
Depends on:
Blocks: 196091
  Show dependency tree / graph
 
Reported: 2019-03-21 12:22 PDT by Robin Morisset
Modified: 2019-03-21 14:06 PDT (History)
5 users (show)

See Also:

Attachments
Patch (24.44 KB, patch)
2019-03-21 12:27 PDT, Robin Morisset 		no flags Details | Formatted Diff | Diff
Patch (28.77 KB, patch)
2019-03-21 13:08 PDT, Robin Morisset 		no flags Details | Formatted Diff | Diff
Patch (30.42 KB, patch)
2019-03-21 13:56 PDT, Robin Morisset 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2019-03-21 12:22:56 PDT 
Mostly useful for https://bugs.webkit.org/show_bug.cgi?id=196091
It also allows us to give names to the children (cond/ifTrue/ifFalse).
Comment 1 Robin Morisset 2019-03-21 12:27:01 PDT 
Created attachment 365589 [details]
Patch

It passes testb3 in Release mode.
The select tests also pass in Debug mode, but I could not test the whole file in Debug mode because of https://bugs.webkit.org/show_bug.cgi?id=196103.
Comment 2 Robin Morisset 2019-03-21 13:08:06 PDT 
Created attachment 365600 [details]
Patch

Remembering to svn add the new files.
Comment 3 EWS Watchlist 2019-03-21 13:13:30 PDT 
Attachment 365600 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/b3/B3Value.h:419:  Missing space before {  [whitespace/braces] [5]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Robin Morisset 2019-03-21 13:56:43 PDT 
Created attachment 365611 [details]
Patch

I had forgotten to update FTLOutput.cpp and WASMB3IRGenerator.cpp
Comment 5 Robin Morisset 2019-03-21 14:06:17 PDT 
Phil suggested a better approach in https://bugs.webkit.org/show_bug.cgi?id=196091