Bug 196103 - testB3::testReportUsedRegistersLateUseFollowedByEarlyDefDoesNotMarkUseAsDead() has a validation failure in debug mode
Summary: testB3::testReportUsedRegistersLateUseFollowedByEarlyDefDoesNotMarkUseAsDead(...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robin Morisset
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-21 12:20 PDT by Robin Morisset
Modified: 2020-06-15 17:10 PDT (History)
7 users (show)

See Also:


Attachments
Patch (3.48 KB, patch)
2020-06-15 16:32 PDT, Robin Morisset
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2019-03-21 12:20:11 PDT
On top-of-tree (only in debug mode):

BB#0: ; frequency = 1.000000
    Void @0 = Patchpoint($42(@1):Register(%rax), $42(@1):Register(%rcx), $42(@1):Register(%rdx), $42(@1):Register(%rbx), $42(@1):Register(%rsi), $42(@1):Register(%rdi), $42(@1):Register(%r8), $42(@1):Register(%r9), $42(@1):Register(%r10), $42(@1):Register(%r11), $42(@1):Register(%r12), $42(@1):Register(%r13), $42(@1):Register(%r14), $42(@1):Register(%r15), generator = 0x1187a2250, earlyClobbered = [], lateClobbered = [], usedRegisters = [], resultConstraint = WarmAny, ExitsSideways|ControlDependent|WritesPinned|ReadsPinned|Fence|Writes:Top|Reads:Top)
    Int32 @1 = Const32(42)
    Void @2 = Patchpoint($10(@3):LateRegister(%rax), $10(@3):LateRegister(%rcx), $10(@3):LateRegister(%rdx), $10(@3):LateRegister(%rbx), $10(@3):LateRegister(%rsi), $10(@3):LateRegister(%rdi), $10(@3):LateRegister(%r8), $10(@3):LateRegister(%r9), $10(@3):LateRegister(%r10), $10(@3):LateRegister(%r11), $10(@3):LateRegister(%r12), $10(@3):LateRegister(%r13), $10(@3):LateRegister(%r14), $10(@3):LateRegister(%r15), generator = 0x118f18c30, earlyClobbered = [], lateClobbered = [], usedRegisters = [], resultConstraint = WarmAny, ExitsSideways|ControlDependent|WritesPinned|ReadsPinned|Fence|Writes:Top|Reads:Top)
    Int32 @3 = Const32(10)
    Int32 @4 = Patchpoint(generator = 0x118f18c48, earlyClobbered = [], lateClobbered = [], usedRegisters = [], resultConstraint = SomeEarlyRegister, ExitsSideways|ControlDependent|WritesPinned|ReadsPinned|Fence|Writes:Top|Reads:Top)
    Void @5 = Return(Terminal)
B3 VALIDATION FAILURE
    valueIndex.get(value) > valueIndex.get(child) (./b3/B3Validate.cpp:104)
    At @0->$42(@1)
    After initial

This test was introduced in https://bugs.webkit.org/show_bug.cgi?id=195303
Comment 1 Radar WebKit Bug Importer 2019-12-10 14:23:55 PST
<rdar://problem/57808549>
Comment 2 Robin Morisset 2020-06-15 16:32:02 PDT
Created attachment 401956 [details]
Patch
Comment 3 Keith Miller 2020-06-15 16:40:42 PDT
Comment on attachment 401956 [details]
Patch

r=me
Comment 4 Robin Morisset 2020-06-15 16:50:57 PDT
(In reply to Keith Miller from comment #3)
> Comment on attachment 401956 [details]
> Patch
> 
> r=me

Thanks for the review.
Comment 5 EWS 2020-06-15 17:10:35 PDT
Committed r263068: <https://trac.webkit.org/changeset/263068>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401956 [details].