Bug 196084 - Remove the SVG tear off objects for SVGNumber, SVGNumberList and SVGAnimatedNumberList
Summary: Remove the SVG tear off objects for SVGNumber, SVGNumberList and SVGAnimatedN...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on: 195905
Blocks: 191237
  Show dependency treegraph
 
Reported: 2019-03-21 10:15 PDT by Said Abou-Hallawa
Modified: 2019-03-21 21:45 PDT (History)
9 users (show)

See Also:


Attachments
Patch (150.04 KB, patch)
2019-03-21 13:52 PDT, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff
Patch for review (66.82 KB, patch)
2019-03-21 13:54 PDT, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff
Patch (65.26 KB, patch)
2019-03-21 17:15 PDT, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff
Patch (66.04 KB, patch)
2019-03-21 17:50 PDT, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-highsierra-wk2 (2.99 MB, application/zip)
2019-03-21 20:28 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2019-03-21 10:15:46 PDT
This is part of removing the tear off objects of the SVG properties.
Comment 1 Said Abou-Hallawa 2019-03-21 13:52:32 PDT
Created attachment 365609 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-03-21 13:53:41 PDT
<rdar://problem/49122470>
Comment 3 Said Abou-Hallawa 2019-03-21 13:54:16 PDT
Created attachment 365610 [details]
Patch for review
Comment 4 Said Abou-Hallawa 2019-03-21 17:15:39 PDT
Created attachment 365650 [details]
Patch
Comment 5 Simon Fraser (smfr) 2019-03-21 17:38:26 PDT
Comment on attachment 365650 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365650&action=review

> Source/WebCore/svg/properties/SVGAnimationAdditiveListFunctionImpl.h:58
> +        const Vector<Ref<SVGNumber>>& fromItems = m_animationMode == AnimationMode::To ? animated->items() : m_from->items();
> +        const Vector<Ref<SVGNumber>>& toItems = m_to->items();
> +        const Vector<Ref<SVGNumber>>& toAtEndOfDurationItems = toAtEndOfDuration()->items();

auto?
Comment 6 Said Abou-Hallawa 2019-03-21 17:50:51 PDT
Created attachment 365656 [details]
Patch
Comment 7 EWS Watchlist 2019-03-21 20:28:57 PDT
Comment on attachment 365656 [details]
Patch

Attachment 365656 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11608462

New failing tests:
imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-constructor.html
Comment 8 EWS Watchlist 2019-03-21 20:28:58 PDT
Created attachment 365672 [details]
Archive of layout-test-results from ews107 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 9 WebKit Commit Bot 2019-03-21 21:45:32 PDT
Comment on attachment 365656 [details]
Patch

Clearing flags on attachment: 365656

Committed r243362: <https://trac.webkit.org/changeset/243362>
Comment 10 WebKit Commit Bot 2019-03-21 21:45:34 PDT
All reviewed patches have been landed.  Closing bug.