Bug 196084 – Remove the SVG tear off objects for SVGNumber, SVGNumberList and SVGAnimatedNumberList

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Said Abou-Hallawa]

This is part of removing the tear off objects of the SVG properties.

[Said Abou-Hallawa]

Created attachment 365609 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/49122470>

[Said Abou-Hallawa]

Created attachment 365610 [details]
Patch for review

[Said Abou-Hallawa]

Created attachment 365650 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 365650 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365650&action=review

> Source/WebCore/svg/properties/SVGAnimationAdditiveListFunctionImpl.h:58
> +        const Vector<Ref<SVGNumber>>& fromItems = m_animationMode == AnimationMode::To ? animated->items() : m_from->items();
> +        const Vector<Ref<SVGNumber>>& toItems = m_to->items();
> +        const Vector<Ref<SVGNumber>>& toAtEndOfDurationItems = toAtEndOfDuration()->items();

auto?

[Said Abou-Hallawa]

Created attachment 365656 [details]
Patch

[EWS Watchlist]

Comment on attachment 365656 [details]
Patch

Attachment 365656 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11608462

New failing tests:
imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-constructor.html

[EWS Watchlist]

Created attachment 365672 [details]
Archive of layout-test-results from ews107 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Comment on attachment 365656 [details]
Patch

Clearing flags on attachment: 365656

Committed r243362: <https://trac.webkit.org/changeset/243362>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.