RESOLVED FIXED 195905
Remove the SVG tear off objects for SVGPoint, SVGPointList and SVGAnimatedPointList 
https://bugs.webkit.org/show_bug.cgi?id=195905
Summary Remove the SVG tear off objects for SVGPoint, SVGPointList and SVGAnimatedPoi...
Said Abou-Hallawa
Reported 2019-03-18 13:08:51 PDT
This requires adding new classes for the SVG property and SVG property list types. It also requires new accessor, new animator and new animation function for accessing and animating the SVGAnimatedPointList. SVGPointList will not be backed by SVGPointListValues.
Attachments
Patch (307.30 KB, patch)
2019-03-18 13:11 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch for review (98.18 KB, patch)
2019-03-18 13:13 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Patch (91.30 KB, patch)
2019-03-21 01:57 PDT, Said Abou-Hallawa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Said Abou-Hallawa
Comment 1 2019-03-18 13:11:31 PDT
Created attachment 365048 [details] Patch
Said Abou-Hallawa
Comment 2 2019-03-18 13:13:12 PDT
Created attachment 365050 [details] Patch for review
Jon Lee
Comment 3 2019-03-20 12:44:06 PDT
Is a new patch going to be uploaded?
Said Abou-Hallawa
Comment 4 2019-03-21 01:57:58 PDT
Created attachment 365520 [details] Patch
Simon Fraser (smfr)
Comment 5 2019-03-21 13:17:22 PDT
Comment on attachment 365520 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365520&action=review > Source/WebCore/svg/SVGPointList.h:82 > + append(SVGPoint::create(FloatPoint(xPos, yPos))); append(SVGPoint::create({ xPos, yPos }));
Radar WebKit Bug Importer
Comment 6 2019-03-21 13:42:04 PDT
<rdar://problem/49121824>
Said Abou-Hallawa
Comment 7 2019-03-21 15:22:30 PDT
Committed r243336: <https://trac.webkit.org/changeset/243336>
Michael Catanzaro
Comment 8 2019-03-24 10:11:00 PDT
It introduced a warning spam. Please remember to be careful about pessimizing move: DerivedSources/ForwardingHeaders/wtf/StdLibExtras.h:572:64: warning: moving a local object in a return statement prevents copy elision [-Wpessimizing-move] 572 | #define WTFMove(value) std::move<WTF::CheckMoveParameter>(value) | ^ ../../Source/WebCore/svg/properties/SVGPropertyList.h:120:16: note: in expansion of macro ‘WTFMove’ 120 | return WTFMove(item); | ^~~~~~~ DerivedSources/ForwardingHeaders/wtf/StdLibExtras.h:572:64: note: remove ‘std::move’ call 572 | #define WTFMove(value) std::move<WTF::CheckMoveParameter>(value) | ^ ../../Source/WebCore/svg/properties/SVGPropertyList.h:120:16: note: in expansion of macro ‘WTFMove’ 120 | return WTFMove(item); | ^~~~~~~
Michael Catanzaro
Comment 9 2019-03-24 10:17:09 PDT
Committed r243421: <https://trac.webkit.org/changeset/243421>
Note You need to log in before you can comment on or make changes to this bug.