Bug 196018 – [iOS] Group UIWebFormAccessoryDelegate-related code and tighten it up a bit

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Daniel Bates]

-[WKContentView _updateAccessory] is called from -hideKeyboard, which is invoked when we commit a load and don't have a form accessory view. No need to send nil messages as part of trying to update the non-existent form accessory view in this case. We should also group all UIWebFormAccessoryDelegate protocol methods for ease of discoverability and it's not possible to show and hide the AutoFill button from -_updateAccessory because we the show case needs a title based on the current design of the button added in bug #131343. So, remove a long standing FIXME.

[Daniel Bates]

Created attachment 365368 [details]
Patch

[Wenson Hsieh]

Comment on attachment 365368 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365368&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3753
> +    _page->setFocusedElementValue(String { });

Nit - wouldn't just { } be more concise?

[Daniel Bates]

(In reply to Wenson Hsieh from comment #2)
> Comment on attachment 365368 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=365368&action=review
> 
> > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3753
> > +    _page->setFocusedElementValue(String { });
> 
> Nit - wouldn't just { } be more concise?

OK

[Daniel Bates]

Created attachment 365377 [details]
To land

[Daniel Bates]

Committed r243221: <https://trac.webkit.org/changeset/243221>

[Radar WebKit Bug Importer]

<rdar://problem/49072320>