Bug 131343 - [Cocoa] Add WKFormDelegate
Summary: [Cocoa] Add WKFormDelegate
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-07 20:13 PDT by mitz
Modified: 2014-04-11 12:20 PDT (History)
1 user (show)

See Also:

Attachments
Add _WKFormDelegate (20.76 KB, patch)
2014-04-07 21:48 PDT, mitz 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2014-04-07 20:13:41 PDT 
[Cocoa] Add WKFormDelegate
Comment 1 mitz 2014-04-07 21:48:14 PDT 
Created attachment 228801 [details]
Add _WKFormDelegate
Comment 2 Anders Carlsson 2014-04-08 08:30:22 PDT 
Comment on attachment 228801 [details]
Add _WKFormDelegate

View in context: https://bugs.webkit.org/attachment.cgi?id=228801&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:145
> +    NSObject <NSSecureCoding> *_userObject;

Please use a RetainPtr here.

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1946
>  - (void)_startAssistingNode:(const AssistedNodeInformation&)information userObject:(NSObject <NSSecureCoding> *)userObject

I think you should rename this method.
Comment 3 mitz 2014-04-08 10:18:23 PDT 
Committed <http://trac.webkit.org/r166933>.