195959 – Web Inspector: refactor WI.TimelineDataGridNode and its subclasses to unify the API surface

Bug 195959 - Web Inspector: refactor WI.TimelineDataGridNode and its subclasses to unify the API surface

Summary: Web Inspector: refactor WI.TimelineDataGridNode and its subclasses to unify t...

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Web Inspector (show other bugs)
Version:	WebKit Nightly Build
Hardware:	All All

Importance:	P2 Normal
Assignee:	Devin Rousso

URL:
Keywords:	InRadar

Depends on:
Blocks:	191901
	Show dependency tree / graph

Reported:	2019-03-19 11:58 PDT by Devin Rousso
Modified:	2019-03-20 10:43 PDT (History)
CC List:	7 users (show)

See Also:

Attachments
Patch (64.89 KB, patch) 2019-03-19 13:02 PDT, Devin Rousso	no flags	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews104 for mac-highsierra-wk2 (2.99 MB, application/zip) 2019-03-19 14:48 PDT, EWS Watchlist	no flags	Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Devin Rousso 2019-03-19 11:58:26 PDT

Unify the API surface of all of the `WI.TimelineDataGridNode` subclasses so that they can all work nicely with the `WI.OverviewTimelineView`.

Comment 1 Radar WebKit Bug Importer 2019-03-19 11:59:36 PDT

<rdar://problem/49028896>

Comment 2 Devin Rousso 2019-03-19 13:02:25 PDT

Created attachment 365214 [details]
Patch

Comment 3 EWS Watchlist 2019-03-19 14:48:48 PDT Comment hidden (obsolete)

Comment on attachment 365214 [details]
Patch

Attachment 365214 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11570494

New failing tests:
http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable.html

Comment 4 EWS Watchlist 2019-03-19 14:48:50 PDT Comment hidden (obsolete)

Created attachment 365230 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

Comment 5 WebKit Commit Bot 2019-03-20 10:43:10 PDT

Comment on attachment 365214 [details]
Patch

Clearing flags on attachment: 365214

Committed r243213: <https://trac.webkit.org/changeset/243213>

Comment 6 WebKit Commit Bot 2019-03-20 10:43:12 PDT

All reviewed patches have been landed.  Closing bug.