Bug 191901 – Web Inspector: Timelines: flatten the overview to show all records, one per line

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

Instead of having the nested view of timeline records when none of the specific timelines are selected, we should have the overview be a combination of all of the specific timelines.  This will be better for developers as it provides an "absolute" ordering of timeline records, meaning it would be possible to look for related events based on time.

[Devin Rousso]

Created attachment 355450 [details]
Patch

[Devin Rousso]

Created attachment 355451 [details]
[Image] After Patch is applied

[Devin Rousso]

Created attachment 355452 [details]
Patch

[Devin Rousso]

Created attachment 355454 [details]
Patch

[Devin Rousso]

Created attachment 355609 [details]
Patch

[Joseph Pecoraro]

We should be able to toggle between the grouped and non grouped views. There is an advantage of the grouped view at times (seeing which script is evaluating code and it’s affects. Likewise style invalidation and layout loops

[Devin Rousso]

(In reply to Joseph Pecoraro from comment #6)
> We should be able to toggle between the grouped and non grouped views. There
> is an advantage of the grouped view at times (seeing which script is
> evaluating code and it’s affects. Likewise style invalidation and layout
> loops
I agree.  Considering the already large size of this patch, I was planning on having it be a followup, but the removal of some of the code/files in the patch may inhibit that.  I'll look into adding it back to this patch.

[Radar WebKit Bug Importer]

<rdar://problem/46423618>

[Joseph Pecoraro]

Comment on attachment 355609 [details]
Patch

r- for now, since this really should be an option to toggle between modes.

[Devin Rousso]

Created attachment 358176 [details]
Patch

[Timothy Hatcher]

I agree this should be a toggle. Both modes have their benefits.

[Devin Rousso]

Created attachment 365237 [details]
Patch

[Devin Rousso]

Created attachment 365238 [details]
[Image] After Patch is applied

[Timothy Hatcher]

After looking at this more, I think there is information missing from the view now that is can be ungrouped. The records can be in any order now, so they really need some indication what resource they are from — where you will go if you click.

I think showing them in the sidebar like:

[S] Style Invalidated — [<>] webkit.org
[S] Script Evaluated — [JS] global.js
[S] Script Evaluated — [JS] wp-embed.min.js

etc.

[Devin Rousso]

(In reply to Timothy Hatcher from comment #14)
> After looking at this more, I think there is information missing from the
> view now that is can be ungrouped. The records can be in any order now, so
> they really need some indication what resource they are from — where you
> will go if you click.
> 
> I think showing them in the sidebar like:
> 
> [S] Style Invalidated — [<>] webkit.org
> [S] Script Evaluated — [JS] global.js
> [S] Script Evaluated — [JS] wp-embed.min.js
> 
> etc.
I like it!  FWIW, we didn't used to show this because all of the script types were on the same line.  I'll figure something out :)

[Devin Rousso]

Created attachment 365500 [details]
Patch

[Devin Rousso]

Created attachment 365501 [details]
[Image] After Patch is applied

[WebKit Commit Bot]

Comment on attachment 365500 [details]
Patch

Clearing flags on attachment: 365500

Committed r243301: <https://trac.webkit.org/changeset/243301>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.