Bug 195865 – Web Inspector: Timeline: lazily create the agent

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

.

[Radar WebKit Bug Importer]

<rdar://problem/48965403>

[Devin Rousso]

Created attachment 364981 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 364981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364981&action=review

r=me

> Source/WebCore/inspector/agents/InspectorTimelineAgent.cpp:719
> +    record->setString("frameId", pageAgent->frameId(frame));

Nit: "frameId"_s to use ASCIILiteral construction.

[Devin Rousso]

Created attachment 365061 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 365061 [details]
Patch

Clearing flags on attachment: 365061

Committed r243119: <https://trac.webkit.org/changeset/243119>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Shawn Roberts]

This commit is causing 2 new failures in the following tests on all of Mac

inspector/timeline/line-column.html
inspector/timeline/setInstruments-programmatic-capture.html

Reproduced with:

run-webkit-tests inspector/timeline/setInstruments-programmatic-capture.html --iterations 10 -f 
run-webkit-tests inspector/timeline/line-column.html -- iterations 10 -f

all iterations produce a text diff failure in 243119
all iterations pass in 243116


Flakiness Dashboard: 

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Ftimeline%2Fline-column.html%20inspector%2Ftimeline%2FsetInstruments-programmatic-capture.html

Diff:

https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/r243136%20(3171)/inspector/timeline/line-column-diff.txt

https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/r243136%20(3171)/inspector/timeline/setInstruments-programmatic-capture-diff.txt

[Devin Rousso]

(In reply to Shawn Roberts from comment #7)
> This commit is causing 2 new failures in the following tests on all of Mac
> 
> inspector/timeline/line-column.html
> inspector/timeline/setInstruments-programmatic-capture.html
> 
> Reproduced with:
> 
> run-webkit-tests inspector/timeline/setInstruments-programmatic-capture.html
> --iterations 10 -f 
> run-webkit-tests inspector/timeline/line-column.html -- iterations 10 -f
> 
> all iterations produce a text diff failure in 243119
> all iterations pass in 243116
> 
> 
> Flakiness Dashboard: 
> 
> https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.
> html#showAllRuns=true&tests=inspector%2Ftimeline%2Fline-column.
> html%20inspector%2Ftimeline%2FsetInstruments-programmatic-capture.html
> 
> Diff:
> 
> https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/
> r243136%20(3171)/inspector/timeline/line-column-diff.txt
> 
> https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/
> r243136%20(3171)/inspector/timeline/setInstruments-programmatic-capture-diff.
> txt
Fixed in followup r243155 <http://trac.webkit.org/changeset/243155>.