Bug 195591 – Web Inspector: ScriptProfiler: lazily create the agent

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

.

[Radar WebKit Bug Importer]

<rdar://problem/48791756>

[Devin Rousso]

Created attachment 364985 [details]
Patch

[Devin Rousso]

Created attachment 365107 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 365107 [details]
Patch

Nice, r=me

[Yusuke Suzuki]

Cool!

[EWS Watchlist]

Comment on attachment 365107 [details]
Patch

Attachment 365107 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11559838

New failing tests:
imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-constructor.html

[EWS Watchlist]

Created attachment 365136 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Comment on attachment 365107 [details]
Patch

Rejecting attachment 365107 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 365107, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=365107&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=195591&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 365107 from bug 195591.
Fetching: https://bugs.webkit.org/attachment.cgi?id=365107
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Joseph Pecoraro']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 6 diffs from patch file(s).
patching file Source/JavaScriptCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/JavaScriptCore/inspector/JSGlobalObjectConsoleClient.cpp
patching file Source/JavaScriptCore/inspector/JSGlobalObjectConsoleClient.h
patching file Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp
Hunk #1 FAILED at 76.
Hunk #2 succeeded at 315 with fuzz 2 (offset 3 lines).
1 out of 2 hunks FAILED -- saving rejects to file Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp.rej
patching file Source/WebCore/inspector/InspectorController.cpp
Hunk #1 FAILED at 135.
Hunk #2 succeeded at 198 (offset -3 lines).
1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/inspector/InspectorController.cpp.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Joseph Pecoraro']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/11567894

[Devin Rousso]

Created attachment 365196 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 365196 [details]
Patch

Clearing flags on attachment: 365196

Committed r243160: <https://trac.webkit.org/changeset/243160>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.