Bug 195818 - Remove incremental attribute and search event
Summary: Remove incremental attribute and search event
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: Safari 12
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anne van Kesteren
URL:
Keywords: InRadar, WPTImpact
: 257686 257687 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-03-15 13:43 PDT by mike
Modified: 2023-07-14 12:31 PDT (History)
9 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description mike 2019-03-15 13:43:55 PDT
WebKit implements the following non-standard APIs:

- Document#onsearch
- Element#onsearch
- the `search` event

Neither Firefox nor Edge implement these.

Blink *does* implement these APIs, but the Blink maintainers are currently
investigating the impact of its removal [1]. That issue includes references
to the `incremental` attribute, but I have not seen any indication of its
existence in WebKit.

WebKit currently has at least one open bug concerning the behavior of this
feature [2].

[1] https://github.com/whatwg/html/issues/667
[2] https://bugs.webkit.org/show_bug.cgi?id=13786
Comment 1 Radar WebKit Bug Importer 2019-03-15 13:55:16 PDT
<rdar://problem/48937114>
Comment 2 Simon Pieters (:zcorpan) 2019-10-29 14:14:34 PDT
Tests added in https://github.com/web-platform-tests/wpt/pull/19889

The test results suggest WebKit does support an incremental attribute.
Comment 4 Ahmad Saleem 2023-06-06 10:01:45 PDT
*** Bug 257687 has been marked as a duplicate of this bug. ***
Comment 5 Ahmad Saleem 2023-06-12 07:22:42 PDT
*** Bug 257686 has been marked as a duplicate of this bug. ***
Comment 6 Anne van Kesteren 2023-07-12 11:12:55 PDT
Pull request: https://github.com/WebKit/WebKit/pull/15788
Comment 7 Anne van Kesteren 2023-07-12 11:25:56 PDT
I'm checking with Chromium if they're still interested in doing this: https://bugs.chromium.org/p/chromium/issues/detail?id=690143#c25.

Aditya, are you still comfortable with what you said in https://github.com/WebKit/WebKit/pull/14701#issuecomment-1579407262?
Comment 8 Aditya Keerthi 2023-07-12 13:51:18 PDT
(In reply to Anne van Kesteren from comment #7)
> I'm checking with Chromium if they're still interested in doing this:
> https://bugs.chromium.org/p/chromium/issues/detail?id=690143#c25.
> 
> Aditya, are you still comfortable with what you said in
> https://github.com/WebKit/WebKit/pull/14701#issuecomment-1579407262?

I'm slightly more concerned about removing the "search" event without a link check, since it could it completely break search functionality in apps that rely on it. Whereas, if we removed incremental without a link check, users could still use the enter key to initiate a search.

I'm still comfortable with removing both from the web, but would lean towards keeping the "search" event with a link check, since we don't know the surface of apps we may affect.
Comment 9 EWS 2023-07-14 12:31:19 PDT
Committed 266068@main (99ff08340f12): <https://commits.webkit.org/266068@main>

Reviewed commits have been landed. Closing PR #15788 and removing active labels.