Status bubble display 'pending' for the step which is currently running (on Buildbot). This is because Buildbot send state_string as 'pending' for step-started event.
Created attachment 364655 [details] Patch
Comment on attachment 364655 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364655&action=review > Tools/BuildSlaveSupport/ews-build/events.py:164 > + state_string = step.get('state_string') Could this be 'None' (that's what using the .get would imply)? Would that mess things up?
Comment on attachment 364655 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364655&action=review >> Tools/BuildSlaveSupport/ews-build/events.py:164 >> + state_string = step.get('state_string') > > Could this be 'None' (that's what using the .get would imply)? Would that mess things up? state_string should always be present in step data and the value should not be None. Looking into buildbot code this step event data comes from database directly (in https://github.com/buildbot/buildbot/blob/master/master/buildbot/data/steps.py#L125) https://github.com/buildbot/buildbot/blob/master/master/buildbot/db/model.py#L177 specifies that state_string is not nullable. However, in an unexpected case when this is None, it shouldn't mess up things. Buildbot will send that data as is, and Django app should handle it appropriately. I will test and handle that case (state_string or other data being None) on the Django app side.
> However, in an unexpected case when this is None, it shouldn't mess up things. Buildbot will send that data as is, and Django app should handle it appropriately. I will test and handle that case (state_string or other data being None) on the Django app side. Handling that in ews-app in https://bugs.webkit.org/show_bug.cgi?id=195753
(In reply to Aakash Jain from comment #4) > > However, in an unexpected case when this is None, it shouldn't mess up things. Buildbot will send that data as is, and Django app should handle it appropriately. I will test and handle that case (state_string or other data being None) on the Django app side. > Handling that in ews-app in https://bugs.webkit.org/show_bug.cgi?id=195753 This seems a reasonable way to handle this problem.
Comment on attachment 364655 [details] Patch Clearing flags on attachment: 364655 Committed r242965: <https://trac.webkit.org/changeset/242965>
All reviewed patches have been landed. Closing bug.
<rdar://problem/48902762>