Bug 195753 - [ews-app] Gracefully handle the case when state_string is None
Summary: [ews-app] Gracefully handle the case when state_string is None
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
Keywords: InRadar
Depends on:
Reported: 2019-03-14 11:56 PDT by Aakash Jain
Modified: 2019-03-14 14:45 PDT (History)
7 users (show)

See Also:

Patch (1.96 KB, patch)
2019-03-14 11:59 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-03-14 11:56:15 PDT
ews-app should gracefully handle the case when 'state_string' sent by buildbot is None. Currently it results in a database exception: IntegrityError: NOT NULL constraint failed: ews_step.state_string
Comment 1 Aakash Jain 2019-03-14 11:59:03 PDT
Created attachment 364673 [details]
Comment 2 Jonathan Bedard 2019-03-14 12:02:36 PDT
Assuming we're ok displaying an empty state string (and I think we are), this looks good to me. Note that this is a response to comments I had in <https://bugs.webkit.org/show_bug.cgi?id=195744>.
Comment 3 WebKit Commit Bot 2019-03-14 14:44:41 PDT
Comment on attachment 364673 [details]

Clearing flags on attachment: 364673

Committed r242966: <https://trac.webkit.org/changeset/242966>
Comment 4 WebKit Commit Bot 2019-03-14 14:44:42 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-03-14 14:45:16 PDT