RESOLVED FIXED 195753
[ews-app] Gracefully handle the case when state_string is None 
https://bugs.webkit.org/show_bug.cgi?id=195753
Summary [ews-app] Gracefully handle the case when state_string is None
Aakash Jain
Reported 2019-03-14 11:56:15 PDT
ews-app should gracefully handle the case when 'state_string' sent by buildbot is None. Currently it results in a database exception: IntegrityError: NOT NULL constraint failed: ews_step.state_string
Attachments
Patch (1.96 KB, patch)
2019-03-14 11:59 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-03-14 11:59:03 PDT
Created attachment 364673 [details] Patch
Jonathan Bedard
Comment 2 2019-03-14 12:02:36 PDT
Assuming we're ok displaying an empty state string (and I think we are), this looks good to me. Note that this is a response to comments I had in <https://bugs.webkit.org/show_bug.cgi?id=195744>.
WebKit Commit Bot
Comment 3 2019-03-14 14:44:41 PDT
Comment on attachment 364673 [details] Patch Clearing flags on attachment: 364673 Committed r242966: <https://trac.webkit.org/changeset/242966>
WebKit Commit Bot
Comment 4 2019-03-14 14:44:42 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2019-03-14 14:45:16 PDT
<rdar://problem/48902526>
Note You need to log in before you can comment on or make changes to this bug.