Bug 195687 - Web Inspector: Protocol Logging: log messages with backtrace if inspector^2 is open
Summary: Web Inspector: Protocol Logging: log messages with backtrace if inspector^2 i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-13 11:30 PDT by Devin Rousso
Modified: 2019-03-13 12:59 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.91 KB, patch)
2019-03-13 11:33 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-03-13 11:30:10 PDT
This would make debugging with inspector2 open SO much nicer, as I could see the trace of each command.
Comment 1 Devin Rousso 2019-03-13 11:33:05 PDT
Created attachment 364552 [details]
Patch
Comment 2 Joseph Pecoraro 2019-03-13 11:35:28 PDT
Comment on attachment 364552 [details]
Patch

rs=me.

Should we have a trace that doesn't auto-expand?
Comment 3 Devin Rousso 2019-03-13 11:59:48 PDT
Comment on attachment 364552 [details]
Patch

(In reply to Joseph Pecoraro from comment #2)
> Should we have a trace that doesn't auto-expand?
Eh, if anything I'd make that a global setting.  Creating a specialized path for a non-expanding `console.trace` seems like a detail that developers shouldn't be concerned with (e.g. thats a setting/"preference" of the developer and/or the tools).

<https://webkit.org/b/195690>
Comment 4 WebKit Commit Bot 2019-03-13 12:28:32 PDT
Comment on attachment 364552 [details]
Patch

Clearing flags on attachment: 364552

Committed r242898: <https://trac.webkit.org/changeset/242898>
Comment 5 WebKit Commit Bot 2019-03-13 12:28:34 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-03-13 12:59:11 PDT
<rdar://problem/48859330>