Bug 195690 - Web Inspector: Console: add a setting for controlling auto-expansion of Trace messages
Summary: Web Inspector: Console: add a setting for controlling auto-expansion of Trace...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-13 11:59 PDT by Devin Rousso
Modified: 2019-03-20 11:58 PDT (History)
6 users (show)

See Also:


Attachments
Patch (5.08 KB, patch)
2019-03-13 12:04 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-03-13 11:59:40 PDT
If a lot of `console.trace` calls are being made rapidly, it can "spam" the log with a lot of information that the developer would have to sift through, especially if all the traces auto-expand.
Comment 1 Devin Rousso 2019-03-13 12:04:22 PDT
Created attachment 364558 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2019-03-15 00:02:20 PDT
<rdar://problem/48917329>
Comment 3 Joseph Pecoraro 2019-03-18 21:46:56 PDT
Comment on attachment 364558 [details]
Patch

Hmm, I'm not sure this deserves a setting. Do we have a good reason for it (other then our Inspector protocol traffic logging?)
Comment 4 Devin Rousso 2019-03-19 18:16:53 PDT
(In reply to Joseph Pecoraro from comment #3)
> Comment on attachment 364558 [details]
> Patch
> 
> Hmm, I'm not sure this deserves a setting. Do we have a good reason for it
> (other then our Inspector protocol traffic logging?)
I don't have a "good" reason, but I have run into situations before where when running `console.trace(a, b)` a LOT of times, I'll only really care about ones with a particular value for `a` or `b`, and having to scroll/filter is a bit annoying.  This solves the issue quite nicely :)

I would also prefer it to not be expanded by default.  Rather than making that choice for everyone, a setting lets each person choose for themself.
Comment 5 Timothy Hatcher 2019-03-20 09:01:32 PDT
I could see this being useful. Would be good to know how often many of these settings get used in the wild, so we can cull the unused ones or ones always enabled.
Comment 6 WebKit Commit Bot 2019-03-20 11:58:10 PDT
Comment on attachment 364558 [details]
Patch

Clearing flags on attachment: 364558

Committed r243220: <https://trac.webkit.org/changeset/243220>
Comment 7 WebKit Commit Bot 2019-03-20 11:58:11 PDT
All reviewed patches have been landed.  Closing bug.