Bug 195610 - Move the remaining code to decide whether site specific quirks are needed to Quirks class
Summary: Move the remaining code to decide whether site specific quirks are needed to ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-12 00:26 PDT by Ryosuke Niwa
Modified: 2019-03-12 04:39 PDT (History)
9 users (show)

See Also:


Attachments
Cleanup (13.58 KB, patch)
2019-03-12 00:31 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Patch for landing (13.58 KB, patch)
2019-03-12 04:11 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2019-03-12 00:26:19 PDT
Move the remaining logic to decide whether a site specific quirk is needed or not to Quirks class.
Comment 1 Ryosuke Niwa 2019-03-12 00:31:58 PDT
Created attachment 364364 [details]
Cleanup
Comment 2 Antti Koivisto 2019-03-12 01:31:30 PDT
Comment on attachment 364364 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=364364&action=review

> Source/WebCore/page/Quirks.cpp:80
> +bool Quirks::needsAutoplayPlayPauseEventsQuirk() const

The second 'Quirk' is redundant.
Comment 3 Ryosuke Niwa 2019-03-12 04:10:52 PDT
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 364364 [details]
> Cleanup
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=364364&action=review
> 
> > Source/WebCore/page/Quirks.cpp:80
> > +bool Quirks::needsAutoplayPlayPauseEventsQuirk() const
> 
> The second 'Quirk' is redundant.

Fixed.
Comment 4 Ryosuke Niwa 2019-03-12 04:11:27 PDT
Created attachment 364376 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-03-12 04:38:17 PDT
The commit-queue encountered the following flaky tests while processing attachment 364376 [details]:

legacy-animation-engine/cssom/cssvalue-comparison.html bug 195617 (authors: dino@apple.com and graouts@apple.com)
The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2019-03-12 04:38:56 PDT
Comment on attachment 364376 [details]
Patch for landing

Clearing flags on attachment: 364376

Committed r242792: <https://trac.webkit.org/changeset/242792>
Comment 7 WebKit Commit Bot 2019-03-12 04:38:58 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2019-03-12 04:39:16 PDT
<rdar://problem/48804436>