Bug 195610 – Move the remaining code to decide whether site specific quirks are needed to Quirks class

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Ryosuke Niwa]

Move the remaining logic to decide whether a site specific quirk is needed or not to Quirks class.

[Ryosuke Niwa]

Created attachment 364364 [details]
Cleanup

[Antti Koivisto]

Comment on attachment 364364 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=364364&action=review

> Source/WebCore/page/Quirks.cpp:80
> +bool Quirks::needsAutoplayPlayPauseEventsQuirk() const

The second 'Quirk' is redundant.

[Ryosuke Niwa]

(In reply to Antti Koivisto from comment #2)
> Comment on attachment 364364 [details]
> Cleanup
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=364364&action=review
> 
> > Source/WebCore/page/Quirks.cpp:80
> > +bool Quirks::needsAutoplayPlayPauseEventsQuirk() const
> 
> The second 'Quirk' is redundant.

Fixed.

[Ryosuke Niwa]

Created attachment 364376 [details]
Patch for landing

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 364376 [details]:

legacy-animation-engine/cssom/cssvalue-comparison.html bug 195617 (authors: [e-mail] and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 364376 [details]
Patch for landing

Clearing flags on attachment: 364376

Committed r242792: <https://trac.webkit.org/changeset/242792>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/48804436>