Bug 195547 – Web Inspector: CPU Usage Timeline - Better Thread chart layout values

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

CPU Usage Timeline - Better Thread chart layout values

Rather then layout the thread charts at the maximum usage of all threads, choose a better maximum value to share for the thread views. Try for a multiple for 25 up to 100, otherwise the maximum of a group.

[Joseph Pecoraro]

Created attachment 364240 [details]
[PATCH] Proposed Fix

Won't apply but still reviewable.

[Devin Rousso]

Comment on attachment 364240 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=364240&action=review

rs=me

> Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js:463
> +        let workerMax = 0;

Any reason to not use `-Infinity` like the rest?

> Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js:601
> +            if (value > 75)
> +                return 100;
> +            if (value > 50)
> +                return 75;
> +            if (value > 25)
> +                return 50;
> +            return 25;

NIT: this could be rewritten/simplified as `(Math.floor(value / 25) + 1) * 25`.

[Joseph Pecoraro]

Comment on attachment 364240 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=364240&action=review

>> Source/WebInspectorUI/UserInterface/Views/CPUTimelineView.js:601
>> +            return 25;
> 
> NIT: this could be rewritten/simplified as `(Math.floor(value / 25) + 1) * 25`.

Yeah, I considered doing this when I first wrote it but I left it as is. This cascade is short and simple and makes it easy to play with new values and tweak.

But I'll switch to this. The arithmetic approach is nice if we want to switch to multiples of 10 (something I've considered as well).

[Joseph Pecoraro]

https://trac.webkit.org/r242740

[Radar WebKit Bug Importer]

<rdar://problem/48784034>