Bug 195444 - [JSC] Remove merging must handle values into proven types in CFA
Summary: [JSC] Remove merging must handle values into proven types in CFA
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-07 17:49 PST by Yusuke Suzuki
Modified: 2019-03-07 19:11 PST (History)
6 users (show)

See Also:

Attachments
Patch for landing (8.38 KB, patch)
2019-03-07 18:30 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-03-07 17:49:10 PST 
...
Comment 1 Yusuke Suzuki 2019-03-07 18:05:15 PST 
I've changed the ChangeLog part since OSR entry validates the value with AbstractValue.
We should not consume must handle value as a constant AbstractValue in CFA since we do not have strong assumption that must handle values should be the same constants when kicking off concurrent compilation and actually performing OSR entry.
Comment 2 Yusuke Suzuki 2019-03-07 18:30:16 PST 
Created attachment 363969 [details]
Patch for landing
Comment 3 Yusuke Suzuki 2019-03-07 18:31:18 PST 
Originally, this patch is included in https://bugs.webkit.org/show_bug.cgi?id=195429, and separated after the review. (https://bugs.webkit.org/show_bug.cgi?id=195429#c4).
Comment 4 Yusuke Suzuki 2019-03-07 18:55:01 PST 
Landed in https://trac.webkit.org/changeset/242627/webkit
Comment 5 Radar WebKit Bug Importer 2019-03-07 19:11:18 PST 
<rdar://problem/48700174>