Bug 195429 - [JSC] StringFromCharCode fast path should accept 0xff in DFG and FTL
Summary: [JSC] StringFromCharCode fast path should accept 0xff in DFG and FTL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-07 13:29 PST by Yusuke Suzuki
Modified: 2019-03-07 17:53 PST (History)
6 users (show)

See Also:


Attachments
Patch (12.50 KB, patch)
2019-03-07 14:05 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (12.88 KB, patch)
2019-03-07 14:14 PST, Yusuke Suzuki
sbarati: review+
Details | Formatted Diff | Diff
Patch for landing (4.81 KB, patch)
2019-03-07 17:52 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-03-07 13:29:52 PST
[JSC] Remove merging must handle values into proven types in CFA
Comment 1 Yusuke Suzuki 2019-03-07 14:05:26 PST
Created attachment 363925 [details]
Patch
Comment 2 Mark Lam 2019-03-07 14:11:44 PST
<rdar://problem/48629581>
Comment 3 Yusuke Suzuki 2019-03-07 14:14:47 PST
Created attachment 363926 [details]
Patch
Comment 4 Saam Barati 2019-03-07 17:36:08 PST
Comment on attachment 363926 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363926&action=review

> Source/JavaScriptCore/ChangeLog:45
> +        Since (1) this is just an optimization, (2) type information is already propagated in prediction injection phase, and (3) the must handle value does not show the performance

We should make these separate bugs and patches. r=me on both.
Comment 5 Yusuke Suzuki 2019-03-07 17:36:45 PST
Comment on attachment 363926 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363926&action=review

Thanks!

>> Source/JavaScriptCore/ChangeLog:45
>> +        Since (1) this is just an optimization, (2) type information is already propagated in prediction injection phase, and (3) the must handle value does not show the performance
> 
> We should make these separate bugs and patches. r=me on both.

OK, I'll soon upload the latter part in a separate patch.
Comment 6 Yusuke Suzuki 2019-03-07 17:49:49 PST
I've just moved must handle value part to https://bugs.webkit.org/show_bug.cgi?id=195444
Comment 7 Yusuke Suzuki 2019-03-07 17:52:43 PST
Created attachment 363965 [details]
Patch for landing
Comment 8 Yusuke Suzuki 2019-03-07 17:53:41 PST
Committed r242626: <https://trac.webkit.org/changeset/242626>