Bug 195411 – [PlayStation] Add initialization for JSC shell for PlayStation port

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Stephan Szabo]

Add the library loading, floating point configuration and other necessary pieces for the jsc shell on PlayStation port. The port requires explicit mentioning of dependent libraries, and we need to do this before static initialization. Also, the float point configuration defaults to one that disables denormals, which causes errors for things like Number.MIN_VALUE.

Add test writer for using remote playstation targets for JSC tests along with associated arguments.

[Stephan Szabo]

Created attachment 363881 [details]
Patch for JSC shell initialization and test scripts for PlayStation port

[Ross Kirsling]

Comment on attachment 363881 [details]
Patch for JSC shell initialization and test scripts for PlayStation port

View in context: https://bugs.webkit.org/attachment.cgi?id=363881&action=review

> Tools/Scripts/webkitdirs.pm:476
> +    }
> +    else {
> +        $jscName .= ".exe" if (isAnyWindows());

} elsif (isAnyWindows()) {

[Stephan Szabo]

Created attachment 363931 [details]
Patch for JSC shell initialization and test scripts for PlayStation port

[Stephan Szabo]

Created attachment 363932 [details]
Patch for JSC shell initialization and test scripts for PlayStation port

[Stephan Szabo]

Created attachment 364403 [details]
Patch for JSC shell initialization and test scripts for PlayStation port

Removing outdated comment as noticed by Chris Reid.

[Stephan Szabo]

Created attachment 364405 [details]
Patch for JSC shell initialization and test scripts for PlayStation port

[EWS Watchlist]

Comment on attachment 364405 [details]
Patch for JSC shell initialization and test scripts for PlayStation port

Attachment 364405 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/11479780

New failing tests:
storage/indexeddb/modern/gc-closes-database-private.html

[EWS Watchlist]

Created attachment 364443 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

[Stephan Szabo]

Created attachment 364461 [details]
Patch for JSC shell initialization and test scripts for PlayStation port

[Stephan Szabo]

Created attachment 364848 [details]
Patch for JSC shell initialization and test scripts for PlayStation port

A version of the PlayStation initialization which removes the need for https://bugs.webkit.org/show_bug.cgi?id=194542 by wrapping getcwd/fopen to provide the working directory and wraps main to provide a command line argument for setting the working directory without updating jsc.cpp itself.

Not yet marking this as obsoleting the old patch as this is a parallel approach.

[EWS Watchlist]

Comment on attachment 364848 [details]
Patch for JSC shell initialization and test scripts for PlayStation port

Attachment 364848 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11551439

New failing tests:
storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html

[EWS Watchlist]

Created attachment 365029 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Stephan Szabo]

Created attachment 365084 [details]
Patch for JSC shell initialization and test scripts for PlayStation port

[EWS Watchlist]

Comment on attachment 365084 [details]
Patch for JSC shell initialization and test scripts for PlayStation port

Attachment 365084 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11557007

New failing tests:
imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-constructor.html

[EWS Watchlist]

Created attachment 365102 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[Stephan Szabo]

Created attachment 365763 [details]
Patch for JSC shell initialization for PlayStation port

Moving wrapper functions out into requirements library, so using that. Also separating out the script portion so this should only modify PlayStation specific files.

[Ross Kirsling]

Comment on attachment 365763 [details]
Patch for JSC shell initialization for PlayStation port

View in context: https://bugs.webkit.org/attachment.cgi?id=365763&action=review

Looks alright to me.

> Source/JavaScriptCore/shell/playstation/Initializer.cpp:32
> +__attribute__((constructor(101)))

The internet suggests you only need to specify the priority if there's more than one?

[Stephan Szabo]

We do have some other constructor items in libraries and the floating point initialization code.

[WebKit Commit Bot]

Comment on attachment 365763 [details]
Patch for JSC shell initialization for PlayStation port

Clearing flags on attachment: 365763

Committed r243700: <https://trac.webkit.org/changeset/243700>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/49486933>