Bug 194542 - [JSC] Add JSC shell support for systems that don't provide a working directory
Summary: [JSC] Add JSC shell support for systems that don't provide a working directory
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-12 08:49 PST by Stephan Szabo
Modified: 2019-03-22 10:06 PDT (History)
12 users (show)

See Also:


Attachments
Add --working-directory and related code (4.82 KB, patch)
2019-02-12 08:54 PST, Stephan Szabo
no flags Details | Formatted Diff | Diff
Add --working-directory and related code, move to file-scope NeverDestroyed (4.89 KB, patch)
2019-02-12 09:42 PST, Stephan Szabo
ews: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews202 for win-future (12.86 MB, application/zip)
2019-02-12 11:32 PST, Build Bot
no flags Details
Add --working-directory and related code, move to file-scope NeverDestroyed (4.89 KB, patch)
2019-02-12 11:50 PST, Stephan Szabo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2019-02-12 08:49:13 PST
Add support to the JSC shell for systems that don't provide a working directory to user applications (e.g. PlayStation).

* Add in a --working-directory option to set the base working directory for such systems.
* When a directory has been set with the above, convert paths into absolute paths for opening.
  * fetchModuleFromLocalFileSystem says that it expects only absolute paths already, so no changes were made there.
* For PlayStation, do not try to call to getcwd.
Comment 1 Stephan Szabo 2019-02-12 08:54:30 PST
Created attachment 361799 [details]
Add --working-directory and related code
Comment 2 Stephan Szabo 2019-02-12 09:42:18 PST
Created attachment 361803 [details]
Add --working-directory and related code, move to file-scope NeverDestroyed

Trying a NeverDestroyed static in file-scope to avoid -Wexit-time-destructors failures.
Comment 3 Build Bot 2019-02-12 11:32:26 PST
Comment on attachment 361803 [details]
Add --working-directory and related code, move to file-scope NeverDestroyed

Attachment 361803 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/11123765

New failing tests:
js/dom/custom-constructors.html
Comment 4 Build Bot 2019-02-12 11:32:38 PST
Created attachment 361815 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Comment 5 Stephan Szabo 2019-02-12 11:50:11 PST
Created attachment 361817 [details]
Add --working-directory and related code, move to file-scope NeverDestroyed
Comment 6 Mark Lam 2019-03-22 10:06:19 PDT
Comment on attachment 361817 [details]
Add --working-directory and related code, move to file-scope NeverDestroyed

Taking out of review since the bug has been declared invalid.