WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
194542
[JSC] Add JSC shell support for systems that don't provide a working directory
https://bugs.webkit.org/show_bug.cgi?id=194542
Summary
[JSC] Add JSC shell support for systems that don't provide a working directory
Stephan Szabo
Reported
2019-02-12 08:49:13 PST
Add support to the JSC shell for systems that don't provide a working directory to user applications (e.g. PlayStation). * Add in a --working-directory option to set the base working directory for such systems. * When a directory has been set with the above, convert paths into absolute paths for opening. * fetchModuleFromLocalFileSystem says that it expects only absolute paths already, so no changes were made there. * For PlayStation, do not try to call to getcwd.
Attachments
Add --working-directory and related code
(4.82 KB, patch)
2019-02-12 08:54 PST
,
Stephan Szabo
no flags
Details
Formatted Diff
Diff
Add --working-directory and related code, move to file-scope NeverDestroyed
(4.89 KB, patch)
2019-02-12 09:42 PST
,
Stephan Szabo
ews-watchlist
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from ews202 for win-future
(12.86 MB, application/zip)
2019-02-12 11:32 PST
,
EWS Watchlist
no flags
Details
Add --working-directory and related code, move to file-scope NeverDestroyed
(4.89 KB, patch)
2019-02-12 11:50 PST
,
Stephan Szabo
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Stephan Szabo
Comment 1
2019-02-12 08:54:30 PST
Created
attachment 361799
[details]
Add --working-directory and related code
Stephan Szabo
Comment 2
2019-02-12 09:42:18 PST
Created
attachment 361803
[details]
Add --working-directory and related code, move to file-scope NeverDestroyed Trying a NeverDestroyed static in file-scope to avoid -Wexit-time-destructors failures.
EWS Watchlist
Comment 3
2019-02-12 11:32:26 PST
Comment on
attachment 361803
[details]
Add --working-directory and related code, move to file-scope NeverDestroyed
Attachment 361803
[details]
did not pass win-ews (win): Output:
https://webkit-queues.webkit.org/results/11123765
New failing tests: js/dom/custom-constructors.html
EWS Watchlist
Comment 4
2019-02-12 11:32:38 PST
Created
attachment 361815
[details]
Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Stephan Szabo
Comment 5
2019-02-12 11:50:11 PST
Created
attachment 361817
[details]
Add --working-directory and related code, move to file-scope NeverDestroyed
Mark Lam
Comment 6
2019-03-22 10:06:19 PDT
Comment on
attachment 361817
[details]
Add --working-directory and related code, move to file-scope NeverDestroyed Taking out of review since the bug has been declared invalid.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug