Bug 194984 - Migrate from "fixedPositionRect" to "layoutViewport" in the scrolling tree
Summary: Migrate from "fixedPositionRect" to "layoutViewport" in the scrolling tree
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks: 194973
  Show dependency treegraph
 
Reported: 2019-02-23 18:30 PST by Simon Fraser (smfr)
Modified: 2019-02-24 22:09 PST (History)
11 users (show)

See Also:


Attachments
Patch (46.72 KB, patch)
2019-02-23 18:33 PST, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-02-23 18:30:14 PST
Migrate from "fixedPositionRect" to "layoutViewport" in the scrolling tree
Comment 1 Simon Fraser (smfr) 2019-02-23 18:33:26 PST
Created attachment 362843 [details]
Patch
Comment 2 EWS Watchlist 2019-02-23 18:35:49 PST
Attachment 362843 [details] did not pass style-queue:


ERROR: Source/WebCore/page/scrolling/ScrollingTreeFrameScrollingNode.h:45:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingTreeFrameScrollingNode.h:57:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingTreeFrameScrollingNode.h:58:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 3 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2019-02-23 18:52:22 PST
Comment on attachment 362843 [details]
Patch

rs=me
Comment 4 WebKit Commit Bot 2019-02-24 22:03:28 PST
Comment on attachment 362843 [details]
Patch

Clearing flags on attachment: 362843

Committed r242031: <https://trac.webkit.org/changeset/242031>
Comment 5 WebKit Commit Bot 2019-02-24 22:03:30 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-02-24 22:09:37 PST
<rdar://problem/48353325>