Bug 194973 – Have a single notion of scroll position in the scrolling tree and derive layoutViewport from it

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Have a single notion of scroll position in the scrolling tree and derive layoutViewport from it

[Simon Fraser (smfr)]

Created attachment 362809 [details]
Patch

[Antti Koivisto]

Comment on attachment 362809 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362809&action=review

> Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:63
> +    FloatPoint scrollPosition() const { return m_scrollPosition; }

As discussed, it would be good to clarify in naming this is the current scroll position (here and elsewhere).

[Simon Fraser (smfr)]

Created attachment 362883 [details]
Patch

[Simon Fraser (smfr)]

This new patch goes further down the same path, cleaning up a lot of cruft in the scrolling tree.

[Radar WebKit Bug Importer]

<rdar://problem/48353121>

[Simon Fraser (smfr)]

Created attachment 362884 [details]
Patch

[EWS Watchlist]

Attachment 362884 [details] did not pass style-queue:


ERROR: Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:56:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:57:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:97:  Inline functions should not be annotated with WEBCORE_EXPORT. Remove the macro, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:98:  Inline functions should not be annotated with WEBCORE_EXPORT. Remove the macro, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 4 in 38 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 362884 [details]
Patch

Attachment 362884 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11274279

New failing tests:
fast/scrolling/ios/scroll-iframe.html

[EWS Watchlist]

Created attachment 362887 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Antti Koivisto]

Comment on attachment 362884 [details]
Patch

r=me

[Simon Fraser (smfr)]

Created attachment 363068 [details]
Patch

[EWS Watchlist]

Attachment 363068 [details] did not pass style-queue:


ERROR: Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:56:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:57:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:97:  Inline functions should not be annotated with WEBCORE_EXPORT. Remove the macro, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:98:  Inline functions should not be annotated with WEBCORE_EXPORT. Remove the macro, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 4 in 40 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Created attachment 363069 [details]
Patch

[EWS Watchlist]

Attachment 363069 [details] did not pass style-queue:


ERROR: Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:56:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:57:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:97:  Inline functions should not be annotated with WEBCORE_EXPORT. Remove the macro, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:98:  Inline functions should not be annotated with WEBCORE_EXPORT. Remove the macro, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 4 in 44 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Created attachment 363071 [details]
Patch

[EWS Watchlist]

Attachment 363071 [details] did not pass style-queue:


ERROR: Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:56:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:57:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:97:  Inline functions should not be annotated with WEBCORE_EXPORT. Remove the macro, or move the inline function definition out-of-line.  [build/webcore_export] [4]
ERROR: Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:98:  Inline functions should not be annotated with WEBCORE_EXPORT. Remove the macro, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 4 in 44 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 363071 [details]
Patch

Attachment 363071 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11300136

New failing tests:
fast/scrolling/ios/mixing-user-and-programmatic-scroll-001.html
fast/scrolling/ios/mixing-user-and-programmatic-scroll-004.html
fast/scrolling/ios/mixing-user-and-programmatic-scroll-005.html
fast/scrolling/ios/mixing-user-and-programmatic-scroll-006.html
fast/scrolling/ios/scroll-iframe-004.html

[EWS Watchlist]

Created attachment 363079 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[Frédéric Wang (:fredw)]

Comment on attachment 363071 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=363071&action=review

> Source/WebCore/ChangeLog:113
> [phone]  Simon Fraser  <[e-mail]>

Duplicate change

[Truitt Savell]

The changes in https://trac.webkit.org/changeset/242132/webkit

has caused tiled-drawing/scrolling/scroll-snap/scroll-snap-proximity-mainframe.html

to start timing out flakily.

History:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=tiled-drawing%2Fscrolling%2Fscroll-snap%2Fscroll-snap-proximity-mainframe.html

reproduced with: 
run-webkit-tests tiled-drawing/scrolling/scroll-snap/scroll-snap-proximity-mainframe.html --iterations 200 -f

this test times out on r242132 but not on r242131.

[Simon Fraser (smfr)]

https://trac.webkit.org/changeset/242132/webkit