RESOLVED DUPLICATE of bug 252131 194905
[Win] Implement Minibrowser without WebKitLegacy support 
https://bugs.webkit.org/show_bug.cgi?id=194905
Summary [Win] Implement Minibrowser without WebKitLegacy support
Don Olmstead
Reported 2019-02-21 10:07:05 PST
Minibrowser on Windows currently requires WebKitLegacy support. This should not be the case.
Attachments
Patch (1.25 KB, patch)
2022-01-13 03:42 PST, Yusuke Suzuki 		darin: review+
Hironori.Fujii: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2022-01-13 03:42:56 PST
Created attachment 449041 [details] Patch
Yusuke Suzuki
Comment 2 2022-01-13 03:44:32 PST
WebKitLegacy and DumpRenderTree has many CF code. So, disabling it makes it easy to replace remaining CF things with generic implementation, and we can drop CFLite more easily.
Don Olmstead
Comment 3 2022-01-13 10:22:31 PST
(In reply to Yusuke Suzuki from comment #2) > WebKitLegacy and DumpRenderTree has many CF code. So, disabling it makes it > easy to replace remaining CF things with generic implementation, and we can > drop CFLite more easily. I am all for doing just that, and have some WIP code lying around that tries to remove more CF code, BUT before we can land this we for sure need to move the testing from Legacy to Modern WebKit.
Fujii Hironori
Comment 4 2022-01-13 12:45:04 PST
Yusuke, I'm surprised you are proposing a patch for this. Do you have a concrete problem if WinCairo is still using CFLite? AppleWin is still using WK1. And, no one is actively working on it these days. With WinCairo WK1, it's easy to maintain WK1 part for WinCairo developers. For example, Bug 234503 and Bug 234504. We should have a WinCairo WK2 testing buildbot and fix more test failures and make the tests stable enough before removing WinCairo WK1. Because removing WinCairo WK1 isn't high priority. no one have been working on it.
Fujii Hironori
Comment 5 2022-01-16 12:14:17 PST
Comment on attachment 449041 [details] Patch cq-. Don't land this patch until WinCairo has WK2 testing buildbot.
Fujii Hironori
Comment 6 2023-02-15 13:22:14 PST
*** This bug has been marked as a duplicate of bug 252131 ***
Note You need to log in before you can comment on or make changes to this bug.