Bug 194854 – [GTK] Gardening for unexpected passes

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Diego Pino]

[GTK] Gardening for unexpected passes

[Diego Pino]

Created attachment 362493 [details]
Patch

[Diego Pino]

Summary:

Expected to crash, but passed: (1)

webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html:
	The test is passing since r241120 ([WPE] Implement GStreamer based holepunch).
	The test only passes when using --display-server=xvfb. It's still failing for --display-server=xorg.

Expected to timeout, but passed: (2)

http/tests/contentextensions/block-cookies-in-image-load-in-onunload.html
http/tests/contentextensions/block-image-load-in-onunload.html:
	The tests are passing since r241283 ([GTK][WPE] Add content extensions support in WKTR and unskip layout tests  https://bugs.webkit.org/show_bug.cgi?id=193622).

Expected to fail, but passed: (23)

http/tests/cache/disk-cache/redirect-chain-limits.html:
	Fixed somewhere between [r241656-r241659]. Likely fixed due to r241656 (Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations https://bugs.webkit.org/show_bug.cgi?id=194586)
http/tests/contentextensions/block-cookies-in-csp-report.php
http/tests/contentextensions/block-cookies-in-ping.html
http/tests/contentextensions/block-cookies-send.html
http/tests/contentextensions/block-csp-report.php
http/tests/contentextensions/block-everything-unless-domain-redirect.php
http/tests/contentextensions/block-ping.html
http/tests/contentextensions/fetch-redirect-blocked.html
http/tests/contentextensions/hide-on-csp-report.php
http/tests/contentextensions/hide-on-ping-with-ping-that-redirects.html
http/tests/contentextensions/hide-on-ping.html
http/tests/contentextensions/main-resource-redirect-blocked.php
http/tests/contentextensions/main-resource-redirect-error.html
http/tests/contentextensions/reload-without-contentextensions.html:
	The tests are passing since r241283 ([GTK][WPE] Add content extensions support in WKTR and unskip layout tests https://bugs.webkit.org/show_bug.cgi?id=193622
imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer-mode.html:
	The test is passing since r241585 (Decoding media-capabilities configuration initial support https://bugs.webkit.org/show_bug.cgi?id=191191).
webgl/1.0.2/conformance/context/context-attribute-preserve-drawing-buffer.html:
	The test is passing since r241117 ([JSC] Use BufferInternal single character StringImpl for SmallStrings https://bugs.webkit.org/show_bug.cgi?id=194374)
http/wpt/offscreen-canvas/transferToImageBitmap-webgl.html:
imported/blink/compositing/draws-content/webgl-simple-background.html:
fast/canvas/webgl/match-page-color-space.html:
webgl/1.0.2/conformance/canvas/buffer-offscreen-test.html:
webgl/webgl-texture-image-buffer-reuse.html:
webgl/webgl-box-shadow.html:
webgl/webgl-border.html:
	The test is passing since r241120 ([WPE] Implement GStreamer based holepunch https://bugs.webkit.org/show_bug.cgi?id=193715)

[Adrian Perez]

Comment on attachment 362493 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362493&action=review

Patch looks good, just one comment below.

> LayoutTests/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

As this is a gardening patch, it does not need review and you change it to:

    Unreviewed test gardening.

Then set “cq?”, and leave “r” empty. Once the EWS bots have passed, you
can then switch to “cq+” and let the commit-queue bot land the patch.

(Alternatively: Use “webkit-patch land-safely”, which automates the above)

[Diego Pino]

Created attachment 362494 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 362494 [details]
Patch

Clearing flags on attachment: 362494

Committed r241864: <https://trac.webkit.org/changeset/241864>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/48272136>