RESOLVED FIXED 194851
Remove a "The " in "The The HTTP headers of the response"
https://bugs.webkit.org/show_bug.cgi?id=194851
Summary Remove a "The " in "The The HTTP headers of the response"
scootergrisen
Reported 2019-02-20 01:26:21 PST
In the translation po file for WebKitGTK+ it says: #: ../../../../WebKit/Shared/API/glib/WebKitURIResponse.cpp:173 msgid "The The HTTP headers of the response" Suggest removing one "The ".
Attachments
Patch (1.45 KB, patch)
2019-10-08 15:53 PDT, Adrian Perez
no flags
Adrian Perez
Comment 1 2019-10-08 15:53:46 PDT
EWS Watchlist
Comment 2 2019-10-08 15:54:18 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Carlos Alberto Lopez Perez
Comment 3 2019-10-08 16:32:26 PDT
Comment on attachment 380474 [details] Patch Updating all the translation po files isn't needed as well?
Adrian Perez
Comment 4 2019-10-09 07:44:28 PDT
(In reply to Carlos Alberto Lopez Perez from comment #3) > Comment on attachment 380474 [details] > Patch > > Updating all the translation po files isn't needed as well? The template (.pot) translation file is generated automatically by CMake. AFAIU translators will pick that (and possibly merge it with the existing translations) next time they update the translatable strings, and each .po file will be updated when a translator sends up an updated copy later on.
WebKit Commit Bot
Comment 5 2019-10-10 07:56:42 PDT
The commit-queue encountered the following flaky tests while processing attachment 380474 [details]: imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception.html bug 202799 (author: youennf@gmail.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2019-10-10 07:57:33 PDT
Comment on attachment 380474 [details] Patch Clearing flags on attachment: 380474 Committed r250967: <https://trac.webkit.org/changeset/250967>
WebKit Commit Bot
Comment 7 2019-10-10 07:57:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.