Bug 194723 – Disable safe browsing in WKWebView and remove its WKPreferences API

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Disable safe browsing in WKWebView and remove its WKPreferences API

[Alex Christensen]

Created attachment 362160 [details]
Patch

[Alex Christensen]

<rdar://problem/48122993>

[Geoffrey Garen]

Comment on attachment 362160 [details]
Patch

Failed to run "['Tools/Scripts/build-webkit', '--release']" exit_code: 65
ata/EWS/WebKit/WebKitBuild/TestWebKitAPI.build/Release/TestWebKitAPILibrary.build/Objects-normal/x86_64/ProcessSwapOnNavigation.d --serialize-diagnostics /Volumes/Data/EWS/WebKit/WebKitBuild/TestWebKitAPI.build/Release/TestWebKitAPILibrary.build/Objects-normal/x86_64/ProcessSwapOnNavigation.dia -c /Volumes/Data/EWS/WebKit/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm -o /Volumes/Data/EWS/WebKit/WebKitBuild/TestWebKitAPI.build/Release/TestWebKitAPILibrary.build/Objects-normal/x86_64/ProcessSwapOnNavigation.o
/Volumes/Data/EWS/WebKit/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:2041:41: error: property 'safeBrowsingEnabled' not found on object of type 'WKPreferences *'; did you mean '_safeBrowsingEnabled'?
    [webView configuration].preferences.safeBrowsingEnabled = NO;
                                        ^~~~~~~~~~~~~~~~~~~
                                        _safeBrowsingEnabled
In file included from /Volumes/Data/EWS/WebKit/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:35:
/Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebKit.framework/PrivateHeaders/WKPreferencesPrivate.h:146:92: note: '_safeBrowsingEnabled' declared here
@property (nonatomic, getter=_isSafeBrowsingEnabled, setter=_setSafeBrowsingEnabled:) BOOL _safeBrowsingEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA), ios(WK_IOS_TBA));

[Alex Christensen]

Created attachment 362171 [details]
Patch

[Geoffrey Garen]

Comment on attachment 362171 [details]
Patch

r=me

[EWS Watchlist]

Comment on attachment 362171 [details]
Patch

Attachment 362171 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11166019

New failing tests:
http/tests/adClickAttribution/store-ad-click-attribution.html

[EWS Watchlist]

Created attachment 362186 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[Alex Christensen]

http://trac.webkit.org/r241728

[Truitt Savell]

The changes in https://trac.webkit.org/changeset/241728/webkit

Caused 1 API failure:
Failed

    TestWebKitAPI.SafeBrowsing.Preference
        _RegisterApplication(), FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL.
        
        /Volumes/Data/slave/mojave-release/build/Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:175
        Value of: [webView configuration].preferences._safeBrowsingEnabled
          Actual: true
        Expected: false


and one crashing test:
http/tests/adClickAttribution/store-ad-click-attribution.html

history:
http://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2FadClickAttribution%2Fstore-ad-click-attribution.html

[Alex Christensen]

The crash is fixed by https://bugs.webkit.org/show_bug.cgi?id=194774

[Alex Christensen]

http://trac.webkit.org/r241736 fixes the API test.