Bug 194774 - WebPageProxy::didFinishDocumentLoadForFrame() crashing in WPE and GTK+ ports
Summary: WebPageProxy::didFinishDocumentLoadForFrame() crashing in WPE and GTK+ ports
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Claudio Saavedra
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-18 04:41 PST by Claudio Saavedra
Modified: 2019-02-18 13:39 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.99 KB, patch)
2019-02-18 04:41 PST, Claudio Saavedra 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Claudio Saavedra 2019-02-18 04:41:11 PST 
WebPageProxy::didFinishDocumentLoadForFrame() crashing in WPE and GTK+ ports
Comment 1 Claudio Saavedra 2019-02-18 04:41:31 PST 
Created attachment 362290 [details]
Patch
Comment 2 Claudio Saavedra 2019-02-18 06:44:43 PST 
This was introduced in https://trac.webkit.org/changeset/241451/
Comment 3 Alex Christensen 2019-02-18 12:46:59 PST 
Comment on attachment 362290 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=362290&action=review

Null checking navigation before using it is fine, but the way you did it here makes it hard to read and see where the assignment is done.  Could we keep the assignment on its own line?

> Source/WebKit/ChangeLog:3
> +        WebPageProxy::didFinishDocumentLoadForFrame() crashing in WPE and GTK+ ports

Why is this only WPE and GTK?  Under what conditions does it crash?
Comment 4 Alex Christensen 2019-02-18 13:30:48 PST 
Comment on attachment 362290 [details]
Patch

https://trac.webkit.org/changeset/241735/webkit
Comment 5 Radar WebKit Bug Importer 2019-02-18 13:39:37 PST 
<rdar://problem/48176470>