Bug 194597 - [ews-app] status bubble should be hidden for certain builds
Summary: [ews-app] status bubble should be hidden for certain builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-02-13 10:43 PST by Aakash Jain
Modified: 2019-03-13 04:28 PDT (History)
6 users (show)

See Also:

Attachments
Proposed patch (2.74 KB, patch)
2019-03-12 17:42 PDT, Aakash Jain 		dewei_zhu: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-02-13 10:43:24 PST 
While generating status bubbles (in ews-app) certain build should not generate status bubble. e.g.: builds which were skipped because patch was not relevant to that queue (e.g: non-webkitpy change skipping webkitpy ews queue).
Comment 1 Aakash Jain 2019-03-12 17:42:43 PDT 
Created attachment 364484 [details]
Proposed patch
Comment 2 dewei_zhu 2019-03-13 00:10:39 PDT 
Comment on attachment 364484 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364484&action=review

> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:88
> +        if build and build.result == 3 and re.search(r'Patch .* doesn\'t have relevant changes', build.state_string):

Maybe having class variables for SUCCESS, WARNINGS, FAILURE, SKIPPED and RETRY make this code also StatusBubble._build_bubble more readable. What do you think?
Comment 3 Aakash Jain 2019-03-13 04:26:27 PDT 
> Maybe having class variables for SUCCESS, WARNINGS, FAILURE, SKIPPED and RETRY make this code also StatusBubble._build_bubble more readable. What do you think?
Agree. Since these values are already referenced in multiple places in this file, making that change in a separate patch in https://bugs.webkit.org/show_bug.cgi?id=195668
Comment 4 Aakash Jain 2019-03-13 04:27:54 PDT 
Committed r242880: <https://trac.webkit.org/changeset/242880>
Comment 5 Radar WebKit Bug Importer 2019-03-13 04:28:19 PDT 
<rdar://problem/48843642>