Bug 195668 - [ews-app] Use Buildbot result code variables
Summary: [ews-app] Use Buildbot result code variables
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
Keywords: InRadar
Depends on:
Reported: 2019-03-13 04:24 PDT by Aakash Jain
Modified: 2019-03-13 10:04 PDT (History)
9 users (show)

See Also:

Proposed patch (3.80 KB, patch)
2019-03-13 04:43 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-03-13 04:24:53 PDT
Buildbot result codes are integers (e.g.: 0 for SUCCESS, 1 for WARNINGS etc.). Instead of referring these integers in ews-app code, we should save these values in corresponding variables and refer them by name. It would make the code more readable. 

These result codes are defined in https://github.com/buildbot/buildbot/blob/master/master/buildbot/process/results.py
Comment 1 Aakash Jain 2019-03-13 04:43:57 PDT
Created attachment 364521 [details]
Proposed patch
Comment 2 Jonathan Bedard 2019-03-13 09:26:47 PDT
Unofficial r=me.
Comment 3 WebKit Commit Bot 2019-03-13 10:03:48 PDT
Comment on attachment 364521 [details]
Proposed patch

Clearing flags on attachment: 364521

Committed r242884: <https://trac.webkit.org/changeset/242884>
Comment 4 WebKit Commit Bot 2019-03-13 10:03:49 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-03-13 10:04:20 PDT